Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change build image to debian:oldoldstable to lower GLIBC requierment #14

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Change build image to debian:oldoldstable to lower GLIBC requierment #14

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d919871
use docker container debian oldoldstable so we are not dependent on t…
Th3Dilli Dec 27, 2023
402751e
split build dep install
Th3Dilli Dec 27, 2023
2843399
use debian repo for powershell
Th3Dilli Dec 27, 2023
1c0d888
remove old run matrix since we now use the docker image
Th3Dilli Jan 18, 2024
e731e19
readd runson with ubuntu latest althogh the debian image is used to r…
Th3Dilli Jan 18, 2024
46fc8a1
revert whitespace changes
Th3Dilli Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,24 @@ jobs:
env:
NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }}

runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest
container: debian:oldoldstable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be more stable to just fix the version in place so that we manually control which debian/ubuntu version we are compiling against?

Copy link
Contributor Author

@Th3Dilli Th3Dilli Jan 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do that too, my general idea was that debian:oldoldstable is the oldest still supported version many other distos depend upon, so that way we stay on a version that is still generally used by some linux distos while not yet being too old.

Further this kinda auto updates which has pros and cons since well it auto updates so it stays updated / patched but also may break when a new version gets released and some one did not directly update their system and the newer glibc is not working anymore since OpenTK requires the newer one already

strategy:
fail-fast: true
matrix:
os: [ubuntu-latest]

steps:
- name: Install X11 dependencies
run: |
sudo apt-get update
sudo apt-get install xorg-dev libwayland-dev libxkbcommon-dev wayland-protocols extra-cmake-modules
apt-get update
apt-get install -y xorg-dev libwayland-dev libxkbcommon-dev wayland-protocols extra-cmake-modules
- name: Install build dependencies
run: |
apt-get install -y curl wget git cmake
VERSION_ID=$(awk -F= '/^VERSION_ID=/{gsub(/"/, "", $2); print $2}' /etc/os-release)
wget -q https://packages.microsoft.com/config/debian/$VERSION_ID/packages-microsoft-prod.deb
dpkg -i packages-microsoft-prod.deb
apt-get update
apt-get install -y powershell
- uses: actions/checkout@v3
- name: Setup .NET Core
uses: actions/setup-dotnet@v3
Expand Down