fix(grid): [grid] fix grid error e2e test #2815
Conversation
WalkthroughThe pull request modifies a test case for a multi-line editing feature in a grid editor application. The changes focus on enhancing the specificity of visibility checks for textboxes within cell roles. The test now checks the visibility of textboxes for two specific companies, "GFD 科技有限公司" and "WWWW 科技有限公司", by targeting nested elements within cell contexts. Changes
Possibly related PRs
Suggested labels
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses an issue with the grid component's end-to-end test by modifying the test to check for visibility of textboxes within specific cells rather than relying on exact name matches. This change aims to improve the robustness of the test. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -3,5 +3,6 @@ import { test, expect } from '@playwright/test' | |||
| test('多行编辑', async ({ page }) => { | |||
| page.on('pageerror', (exception) => expect(exception).toBeNull()) | |||
| await page.goto('grid-editor#editor-custom-edit') | |||
| await expect(page.getByRole('textbox', { name: 'GFD 科技有限公司', exact: true })).toBeVisible() | |||
| await expect(page.getByRole('cell', { name: 'GFD 科技有限公司' }).getByRole('textbox')).toBeVisible() | |||
There was a problem hiding this comment.
The change from checking for a textbox with an exact name match to checking for a textbox within a cell is a good improvement for test robustness. However, ensure that the new cell names ('GFD 科技有限公司' and 'WWWW 科技有限公司') are consistently present in the test environment to avoid false negatives.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/sites/demos/pc/app/grid/editor/custom-edit.spec.js (1)
6-7: LGTM! The test improvements look good.The changes follow Playwright's best practices by:
- Using role-based selectors (
getByRole) which are more reliable than other selector types- Properly chaining selectors to ensure textboxes are found within their respective cells
- Testing multiple rows to ensure consistent behavior
However, consider adding error messages to the assertions to make test failures more descriptive:
- await expect(page.getByRole('cell', { name: 'GFD 科技有限公司' }).getByRole('textbox')).toBeVisible() - await expect(page.getByRole('cell', { name: 'WWWW 科技有限公司' }).getByRole('textbox')).toBeVisible() + await expect(page.getByRole('cell', { name: 'GFD 科技有限公司' }).getByRole('textbox')).toBeVisible({ timeout: 5000 }, 'Textbox for GFD company should be visible') + await expect(page.getByRole('cell', { name: 'WWWW 科技有限公司' }).getByRole('textbox')).toBeVisible({ timeout: 5000 }, 'Textbox for WWWW company should be visible')
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/sites/demos/pc/app/grid/editor/custom-edit.spec.js(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit