-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: [button] change ubuntu-latest to ubuntu-22.04 when run e2e test #2791
Conversation
WalkthroughThe pull request involves updating the GitHub Actions workflow configurations for various test-related workflows. Specifically, the changes modify the runner environment from Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request updates the CI configuration by changing the Ubuntu version from Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test-e2e-dispatch.yml (1)
20-20
: LGTM! Good practice to pin the Ubuntu version.The change from
ubuntu-latest
toubuntu-22.04
is a positive improvement that enhances stability and reproducibility of the E2E tests by using a specific Ubuntu version instead of a moving target.Consider adding a comment in the workflow file or updating the documentation to explain:
- Why Ubuntu 22.04 was chosen
- When the team should consider upgrading to the next LTS version
name: Dispatch Tests timeout-minutes: 60 + # Using Ubuntu 22.04 LTS for stable and reproducible test environment + # TODO: Plan upgrade to next LTS version before April 2027 (end of standard support) runs-on: ubuntu-22.04
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/test-e2e-all.yml
(2 hunks).github/workflows/test-e2e-dispatch.yml
(1 hunks).github/workflows/test-e2e-pr-comment.yml
(1 hunks).github/workflows/test-e2e-pr.yml
(2 hunks).github/workflows/test-unit-pr.yml
(2 hunks)
✅ Files skipped from review due to trivial changes (4)
- .github/workflows/test-e2e-pr-comment.yml
- .github/workflows/test-e2e-pr.yml
- .github/workflows/test-unit-pr.yml
- .github/workflows/test-e2e-all.yml
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit