-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collapse): [collapse] fix style issues in the old theme #2579
Conversation
WalkthroughThe changes in this pull request involve modifying a LESS stylesheet for the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)packages/theme/src/collapse-item/vars.less (1)
The change from Let's verify if this color variable is consistently defined across themes: ✅ Verification successfulThe color variable change is safe and well-defined The verification shows that --tv-color-bg-gray-1: var(--tv-base-color-common-2); // #fafafa 灰色背景-1:灰色卡片背景色/表格下展背景色 This confirms that the change aligns with the existing design system and follows the established pattern for gray background colors in the theme. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if --tv-color-bg-gray-1 is defined in theme files
# and ensure it's not causing any undefined variable issues
# Search for the color variable definition
echo "Searching for color variable definition:"
rg --type=less "tv-color-bg-gray-1"
# Check for potential undefined variable warnings in build logs
echo "Checking for any undefined variable warnings:"
rg --type=log "tv-color-bg-gray-1.*undefined"
Length of output: 1163 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit