Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.19.0 to dev #2447

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Release 3.19.0 to dev #2447

merged 6 commits into from
Oct 28, 2024

Conversation

zzcr
Copy link
Member

@zzcr zzcr commented Oct 28, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Introduced new properties to the select component, including searchable, enhancing user interaction with search input for filtering options.
    • Added support for displaying tags with only icons using the only-icon property.
    • New icons added to the icon library for enhanced visual representation.
    • Enhanced styling for tags in "only icon" mode, providing better customization options.
  • Bug Fixes

    • Updated assertions in test cases to reflect changes in expected classes for selected rows in dropdowns.
  • Documentation

    • Improved clarity in documentation for file upload component regarding image type restrictions.
  • Style

    • Adjusted styles for various components, including button icon sizes and select component states for better visual consistency.

Copy link

coderabbitai bot commented Oct 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request encompass modifications across various test scripts and Vue components. Key alterations include updates to SVG visibility checks in Playwright tests, enhancements to component templates by replacing existing components with their "tiny" counterparts, and the introduction of new properties to enhance user interaction. Additionally, documentation has been improved for clarity, and CSS variables have been adjusted for better styling. Overall, the changes aim to refine the functionality and presentation of the components and their corresponding tests.

Changes

File Path Change Summary
examples/sites/demos/pc/app/action-menu/basic-usage.spec.ts Modified SVG visibility check in Playwright test.
examples/sites/demos/pc/app/action-menu/card-mode.spec.ts Updated assertion for SVG path data in Playwright test.
examples/sites/demos/pc/app/action-menu/icon.spec.ts Adjusted action menu selection index in test cases.
examples/sites/demos/pc/app/button-group/show-more.spec.ts Updated regex for SVG path validation in "show more" button test.
examples/sites/demos/pc/app/color-picker/history-composition-api.vue Replaced <ColorPicker> with <tiny-color-picker> and <Button> with <tiny-button>.
examples/sites/demos/pc/app/color-picker/predefine-composition-api.vue Replaced <ColorPicker> with <tiny-color-picker> and <Button> with <tiny-button>.
examples/sites/demos/pc/app/color-select-panel/history-composition-api.vue Replaced <ColorSelectPanel> with <tiny-color-select-panel>.
examples/sites/demos/pc/app/color-select-panel/predefine-composition-api.vue Replaced <ColorSelectPanel> with <tiny-color-select-panel>.
examples/sites/demos/pc/app/date-picker/clear.spec.ts Updated expected attributes for clear icon's SVG path in test.
examples/sites/demos/pc/app/dropdown/basic-usage.spec.ts Removed expectation for specific SVG path attribute in dropdown icon test.
examples/sites/demos/pc/app/file-upload/webdoc/file-upload.js Enhanced clarity of file type restrictions in demo descriptions.
examples/sites/demos/pc/app/grid/editor/custom-editor-select-composition-api.vue Changed editor component from Select to TinySelect.
examples/sites/demos/pc/app/grid/editor/custom-editor-select.vue Changed editor component from Select to TinySelect.
examples/sites/demos/pc/app/grid/editor/mutil-render-composition-api.vue Changed editor component from Select to TinySelect.
examples/sites/demos/pc/app/grid/editor/mutil-render.vue Changed editor component from Select to TinySelect.
examples/sites/demos/pc/app/grid/editor/popeditor-in-grid-remote-search-composition-api.vue Changed editor component from Popeditor to TinyPopeditor.
examples/sites/demos/pc/app/grid/editor/popeditor-in-grid-remote-search.vue Changed editor component from Popeditor to TinyPopeditor.
examples/sites/demos/pc/app/grid/large-data/grid-large-tree-data-composition-api.vue Changed editor component from DatePicker to TinyDatePicker for specific columns.
examples/sites/demos/pc/app/grid/large-data/grid-large-tree-data.vue Changed editor component from DatePicker to TinyDatePicker for specific columns.
examples/sites/demos/pc/app/grid/renderer/async-colunm-render-composition-api.vue Changed editor component from Select to TinySelect.
examples/sites/demos/pc/app/grid/renderer/async-colunm-render.vue Changed editor component from Select to TinySelect.
examples/sites/demos/pc/app/grid/renderer/custom-renderer-composition-api.vue Changed renderer component from Switch to TinySwitch.
examples/sites/demos/pc/app/grid/renderer/custom-renderer.vue Changed renderer component from Switch to TinySwitch.
examples/sites/demos/pc/app/grid/validation/valid-config-composition-api.vue Changed editor component from Input to TinyInput for the name field.
examples/sites/demos/pc/app/grid/validation/valid-config.vue Changed editor component from Input to TinyInput for the name field.
examples/sites/demos/pc/app/grid/validation/validation-scroll-to-col-composition-api.vue Changed editor component from Input to TinyInput for the name field.
examples/sites/demos/pc/app/grid/validation/validation-scroll-to-col.vue Changed editor component from Input to TinyInput for the name field.
examples/sites/demos/pc/app/select/nest-grid-remote.spec.ts Updated selected row class assertion in test cases.
examples/sites/demos/pc/app/select/nest-grid-remote.vue Added console.log for debugging in remoteMethod.
examples/sites/demos/pc/app/select/nest-grid.spec.ts Updated selected row class assertion in test cases.
examples/sites/demos/pc/app/select/nest-radio-grid-much-data.spec.ts Updated selected row class assertion in test case.
examples/sites/demos/pc/app/select/size.spec.ts Updated expected height for mini size input element.
examples/sites/demos/pc/app/slider/max-min.spec.ts Updated expected text values for slider tip in test case.
examples/sites/demos/pc/app/tag/size-composition-api.vue Added new <tiny-tag> components with icons.
examples/sites/demos/pc/app/tag/size.vue Added new <tiny-tag> components with icons.
examples/sites/demos/pc/app/tag/webdoc/tag.js Enhanced documentation clarity for demo properties.
packages/design/aurora/index.ts Removed DialogSelect from exported components.
packages/modules.json Changed mode property formatting and renamed components.
packages/theme/src/button/vars.less Updated icon font size variable for small buttons.
packages/theme/src/index.less Added import for base-select component styles.
packages/theme/src/month-table/index.less Added new styles for month table first and last child elements.
packages/theme/src/month-table/vars.less Added new CSS variables for month table cell border radius.
packages/theme/src/select/index.less Modified styles for select component states and SVG layout.
packages/theme/src/tag/index.less Added new styles for icon-only tags and consolidated styling logic.
packages/theme/src/tag/vars.less Added new CSS variables for "only icon" tags and removed old properties.
packages/vue-icon-saas/index.ts Added new icon imports and exports.
packages/vue/src/select/src/pc.vue Added new properties for enhanced component behavior, including only-icon and searchable.

Poem

In the meadow, changes bloom,
With tiny tags and buttons' room.
Icons dance, and colors play,
New features hop in bright array.
A rabbit's cheer, a joyful tune,
For every change beneath the moon! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zzcr zzcr merged commit 9acc34e into dev Oct 28, 2024
6 checks passed
Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants