Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reexport canvas entry on design-core #552

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

chilingling
Copy link
Member

@chilingling chilingling commented Jun 7, 2024

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Updated rendering functionality to use @opentiny/tiny-engine for improved performance and compatibility.
  • Refactor

    • Removed dependency on @opentiny/tiny-engine-canvas and replaced it with @opentiny/tiny-engine.
  • Chores

    • Updated project dependencies to streamline the codebase.

Copy link
Contributor

coderabbitai bot commented Jun 7, 2024

Walkthrough

The changes involve updating dependencies and import statements across various files in the project. Specifically, the @opentiny/tiny-engine-canvas dependency has been removed in favor of @opentiny/tiny-engine. Additionally, the createRender function is now imported from @opentiny/tiny-engine and exported from design-core's index.js.

Changes

Files Change Summary
designer-demo/package.json Removed dependency: "@opentiny/tiny-engine-canvas".
designer-demo/src/canvas.js Updated import statement from @opentiny/tiny-engine-canvas to @opentiny/tiny-engine.
packages/design-core/index.js Added export of createRender from @opentiny/tiny-engine-canvas and updated exports in package.json.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant CanvasJS as canvas.js
    participant TinyEngine as @opentiny/tiny-engine
    participant DesignCore as design-core/index.js

    CanvasJS->>TinyEngine: import { createRender }
    DesignCore->>TinyEngine: export { createRender }
Loading

Poem

In code's vast and winding lane,
A change was made, not in vain.
From canvas to engine, swift and bright,
Functions moved in morning light.
Dependencies, gone with the breeze,
Our code now dances with more ease.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1724bbc and b900b3b.

Files selected for processing (3)
  • designer-demo/package.json (1 hunks)
  • designer-demo/src/canvas.js (1 hunks)
  • packages/design-core/index.js (1 hunks)
Files skipped from review due to trivial changes (3)
  • designer-demo/package.json
  • designer-demo/src/canvas.js
  • packages/design-core/index.js

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b900b3b and 76ee252.

Files selected for processing (3)
  • designer-demo/src/canvas.js (1 hunks)
  • packages/design-core/canvas.js (1 hunks)
  • packages/design-core/package.json (1 hunks)
Files skipped from review due to trivial changes (2)
  • packages/design-core/canvas.js
  • packages/design-core/package.json
Files skipped from review as they are similar to previous changes (1)
  • designer-demo/src/canvas.js

@hexqi hexqi merged commit d9fe200 into opentiny:refactor/develop Jun 7, 2024
yy-wow pushed a commit to yy-wow/tiny-engine that referenced this pull request Oct 10, 2024
* feat: reexport canvas entry on design-core

* feat: independen entry for canvas
This was referenced Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants