fix: es import error、add build command(comments)、add demo designer... #514
Conversation
WalkthroughThe recent changes introduce several new features and enhancements to the Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
packages/design-core/index.js (1)
50-51: Consider whether the added console logs for the default and merged registry are necessary for production. If they are for debugging purposes, ensure they are removed or guarded by a development flag before deployment.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (4)
packages/design-core/assets/rf-resources/flowchart-ecs.svgis excluded by!**/*.svgpackages/design-core/assets/rf-resources/flowchart-evs.svgis excluded by!**/*.svgpackages/design-core/assets/rf-resources/flowchart-rds.svgis excluded by!**/*.svgpackages/design-core/assets/rf-resources/flowchart-vpc.svgis excluded by!**/*.svg
Files selected for processing (26)
- designer-demo/canvas.html (1 hunks)
- designer-demo/engine.config.js (1 hunks)
- designer-demo/index.html (1 hunks)
- designer-demo/package.json (1 hunks)
- designer-demo/registry.js (1 hunks)
- designer-demo/src/App.vue (1 hunks)
- designer-demo/src/canvas.js (1 hunks)
- designer-demo/src/defineEntry.js (1 hunks)
- designer-demo/src/main.js (1 hunks)
- package.json (1 hunks)
- packages/build/vite-plugin-generate-comments/package.json (1 hunks)
- packages/build/vite-plugin-generate-comments/vite.config.js (1 hunks)
- packages/design-core/index.js (3 hunks)
- packages/design-core/scripts/localCdnFile/copyBundleDeps.js (1 hunks)
- packages/design-core/scripts/localCdnFile/copyImportMap.js (1 hunks)
- packages/design-core/scripts/localCdnFile/copyPreviewImportMap.js (1 hunks)
- packages/design-core/scripts/localCdnFile/index.js (1 hunks)
- packages/design-core/vite.config.js (1 hunks)
- packages/engine-cli/template/registry.js (1 hunks)
- packages/entry/package.json (1 hunks)
- packages/entry/vite.config.js (1 hunks)
- packages/layout/src/index.vue (1 hunks)
- packages/layout/vite.config.js (1 hunks)
- packages/plugins/i18n/meta.js (1 hunks)
- packages/plugins/i18n/src/Main.vue (3 hunks)
- pnpm-workspace.yaml (1 hunks)
Files skipped from review due to trivial changes (9)
- designer-demo/canvas.html
- designer-demo/index.html
- designer-demo/src/canvas.js
- designer-demo/src/main.js
- packages/build/vite-plugin-generate-comments/vite.config.js
- packages/design-core/vite.config.js
- packages/entry/vite.config.js
- packages/layout/src/index.vue
- packages/plugins/i18n/meta.js
Additional comments not posted (21)
pnpm-workspace.yaml (2)
4-4: Including 'designer-demo' in the workspace configuration aligns with the introduction of the demo project.
7-7: Excluding template directories from the workspace is a good practice to streamline operations like testing and linting.packages/design-core/scripts/localCdnFile/index.js (1)
1-5: Correctly updating the export paths to include the.jsextension aligns with ES module standards and resolves import errors.designer-demo/src/App.vue (1)
1-9: The script setup correctly uses Vue's composition API and lifecycle hooks to initialize the tiny engine, adhering to best practices.packages/entry/package.json (1)
5-11: Updating the main and module paths to point to thedistdirectory and adding a build script are appropriate for managing builds and distributions.packages/build/vite-plugin-generate-comments/package.json (1)
5-11: Correctly updating the paths to thedistdirectory and adding a build script ensures the plugin is built and managed properly.designer-demo/package.json (1)
6-21: The configuration of scripts and dependencies in this package.json is well-aligned with the project's goals, ensuring consistency and ease of development.designer-demo/src/defineEntry.js (1)
13-15: Correct use of ES module imports with.jsextensions and proper function invocation.designer-demo/engine.config.js (1)
16-19: Ensure theotherConfigobject is documented for future use, as it's currently empty.packages/layout/vite.config.js (1)
30-35: Configuration forrollupOptionsis appropriate. Verify that all specified external dependencies are correct and necessary.#!/bin/bash # Description: Verify external dependencies in rollup configuration. # Test: Search for external dependencies in the project to ensure they are used and necessary. rg --type js 'vue|@opentiny/tiny-engine.*|@opentiny/vue.*'packages/design-core/scripts/localCdnFile/copyImportMap.js (1)
8-10: Correct update of import paths with.jsextensions. Consider adding detailed comments to complex function logic for better maintainability.packages/engine-cli/template/registry.js (1)
17-94: Extensive additions to toolbar items and plugins. Ensure each new item and plugin is well-documented for clarity and ease of use.designer-demo/registry.js (1)
17-94: Identical additions to toolbar items and plugins as inpackages/engine-cli/template/registry.js. Verify the necessity of duplicating these configurations across different parts of the project.#!/bin/bash # Description: Verify duplication of configurations across different parts of the project. # Test: Search for identical configurations in other parts of the project. rg --type js 'engine.toolbars.logo|engine.plugins.materials'packages/design-core/scripts/localCdnFile/copyBundleDeps.js (2)
3-4: Ensure that the updated import paths with.jsextensions are correct and resolve the ES module import errors as intended.
11-11: Confirm that the import path forlocateCdnNpmInfo.jsis correctly updated to include the.jsextension.packages/design-core/index.js (1)
16-16: Confirm that the renaming fromdefaultResigrytodefaultRegistryis correctly reflected throughout the codebase.packages/design-core/scripts/localCdnFile/copyPreviewImportMap.js (2)
9-9: Ensure that the updated import path forlocateCdnNpmInfo.jsis correct and resolves the ES module import errors as intended.
11-11: Confirm that the import path forinstallPackageTemporary.jsis correctly updated to include the.jsextension.package.json (1)
8-10: Confirm that the new scripts fordev:demoanddev:demo:frontendare correctly set up and functional. Ensure that they do not conflict with existing scripts and that they adhere to the project's scripting conventions.packages/plugins/i18n/src/Main.vue (2)
130-130: Verify that the uncommented import ofBASE_URLis used appropriately within the component and does not introduce any security or functional issues.
291-291: Ensure that thedownloadFilemethod correctly handles the file download process and that the URL construction is secure and does not expose sensitive information.
|
designer-demo 下面后面可能会有多个 demo，建议在 designer-demo/xxx 作为一个 demo 的入口，方便后续添加其他的 demo。 |
There may be multiple demos below designer-demo. It is recommended that designer-demo/xxx be used as the entrance to a demo to facilitate the subsequent addition of other demos. |
…opentiny#514) * feat: add designer demo package * fix: remove useless svg assets * fix: add .js to resolve es import error * fix: add build command in comments and entry * fix: remove metaService * feat: update registry template
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Chores