Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svgs): rollback svgs/index.js #513

Merged
merged 1 commit into from
May 27, 2024
Merged

fix(svgs): rollback svgs/index.js #513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/svgs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
*/

import SvgIcon from './src/Main.vue'
import metaData from './meta.js'

export default (app) => {
app.component('SvgIcon', { ...metaData, SvgIcon })
app.component('SvgIcon', SvgIcon)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure compatibility and document the breaking change.

The removal of metaData in the component registration could affect existing applications that rely on this metadata. It's crucial to document the specific impacts and provide a migration path for users.

Add tests to verify the new component behavior.

It appears that tests covering the new behavior of SvgIcon are missing. Would you like assistance in writing these tests, or should I open a GitHub issue to track this task?

}