Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: resolve block search exceptions" #1015

Merged

Conversation

SonyLeo
Copy link
Contributor

@SonyLeo SonyLeo commented Jan 10, 2025

Reverts #995

Summary by CodeRabbit

  • New Features
    • Enhanced block group transfer component with improved search and data binding capabilities
  • Refactor
    • Simplified block list management and search functionality
    • Removed deprecated computed property for block filtering

Copy link
Contributor

coderabbitai bot commented Jan 10, 2025

Walkthrough

The pull request introduces changes to the BlockGroupPanel.vue file, focusing on modifying the block management and search functionality. The modifications involve transitioning from a one-way to a two-way data binding for block lists, updating the search component's event handling, and removing the filteredBlocks computed property. These changes aim to streamline the data handling and search logic within the component.

Changes

File Change Summary
packages/plugins/materials/src/meta/block/src/BlockGroupPanel.vue - Replaced :blockList prop with v-model:blockList
- Added @update:modelValue event listener to tiny-search
- Removed filteredBlocks computed property
- Deleted utils import

Suggested labels

bug, refactor-main

Suggested reviewers

  • chilingling

Possibly related PRs

Poem

🐰 In the realm of blocks and Vue's embrace,
A refactor dances with elegant grace.
Two-way binding, a search so bright,
Computed props take flight!
Code flows smoother, rabbit's delight! 🔍✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the refactor-main refactor/develop branch feature label Jan 10, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/plugins/materials/src/meta/block/src/BlockGroupPanel.vue (1)

13-20: Reconsider reverting PR #995.

The original PR appears to have improved search functionality by:

  1. Implementing client-side filtering for better responsiveness
  2. Adding input sanitization for search safety

Reverting these changes could reintroduce the issues that PR #995 fixed. Consider keeping the original improvements or implementing alternative solutions that maintain both performance and security.

Also applies to: 32-32

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a834f60 and 41998b9.

📒 Files selected for processing (1)
  • packages/plugins/materials/src/meta/block/src/BlockGroupPanel.vue (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: push-check
🔇 Additional comments (2)
packages/plugins/materials/src/meta/block/src/BlockGroupPanel.vue (2)

13-20: Consider performance implications of removing client-side filtering.

The change from computed property filtering to direct API calls on each search input could impact performance and user experience:

  1. More frequent API calls could introduce latency
  2. Removed client-side filtering might affect search responsiveness

Let's verify the search API's response time and rate limiting:


32-32: Verify server-side input sanitization for search.

The removal of escapeRegExp utility means special characters in search input are no longer escaped client-side. Ensure the server properly sanitizes search input to prevent potential issues.

Let's check for server-side input validation:

@gene9831 gene9831 mentioned this pull request Jan 10, 2025
14 tasks
@hexqi hexqi merged commit 92240b6 into opentiny:refactor/develop Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor-main refactor/develop branch feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants