-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix: resolve block search exceptions" #1015
Revert "fix: resolve block search exceptions" #1015
Conversation
This reverts commit fee84e6.
WalkthroughThe pull request introduces changes to the Changes
Suggested labels
Suggested reviewers
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/plugins/materials/src/meta/block/src/BlockGroupPanel.vue (1)
13-20
: Reconsider reverting PR #995.The original PR appears to have improved search functionality by:
- Implementing client-side filtering for better responsiveness
- Adding input sanitization for search safety
Reverting these changes could reintroduce the issues that PR #995 fixed. Consider keeping the original improvements or implementing alternative solutions that maintain both performance and security.
Also applies to: 32-32
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/plugins/materials/src/meta/block/src/BlockGroupPanel.vue
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: push-check
🔇 Additional comments (2)
packages/plugins/materials/src/meta/block/src/BlockGroupPanel.vue (2)
13-20
: Consider performance implications of removing client-side filtering.The change from computed property filtering to direct API calls on each search input could impact performance and user experience:
- More frequent API calls could introduce latency
- Removed client-side filtering might affect search responsiveness
Let's verify the search API's response time and rate limiting:
32-32
: Verify server-side input sanitization for search.The removal of
escapeRegExp
utility means special characters in search input are no longer escaped client-side. Ensure the server properly sanitizes search input to prevent potential issues.Let's check for server-side input validation:
Reverts #995
Summary by CodeRabbit