Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve to loads all maps in custom folder #988

Merged
merged 6 commits into from
Apr 18, 2023

Conversation

sebbesiren
Copy link
Contributor

Update to load all maps in custom maps folder instead of only the one specified. Loads maximum 50 custom maps.
Removed old configuration and kept the toggle for loading custom maps or not.

Added house, monster and npc xml files to gitignore to avoid pushing these if not intended.

Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small indentations.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit ccb3eae into opentibiabr:main Apr 18, 2023
@dudantas dudantas changed the title feat: now loads all maps in custom folder feat: improve to loads all maps in custom folder Apr 18, 2023
@sebbesiren
Copy link
Contributor Author

@dudantas
Didnt mean to ghost you.
Was a busy weekend, so intended to fix your comments today.
Well, thanks for fixing the indentations etc.

Cheers!

libergod referenced this pull request in libergod/canary_baiak Apr 18, 2023
feat: improve to loads all maps in custom folder (#988)
luan pushed a commit that referenced this pull request Jul 11, 2023
Update to load all maps in custom maps folder instead of only the one specified. Loads maximum 50 custom maps.
Removed old configuration and kept the toggle for loading custom maps or not.

Added house, monster and npc XML files to gitignore to avoid pushing these if not intended.
@sebbesiren sebbesiren deleted the custom-maps branch July 15, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants