-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve to loads all maps in custom folder #988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestyotbr
approved these changes
Apr 8, 2023
beats-dh
reviewed
Apr 11, 2023
majestyotbr
approved these changes
Apr 11, 2023
dudantas
reviewed
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small indentations.
dudantas
reviewed
Apr 17, 2023
dudantas
approved these changes
Apr 17, 2023
Kudos, SonarCloud Quality Gate passed! |
@dudantas Cheers! |
libergod
referenced
this pull request
in libergod/canary_baiak
Apr 18, 2023
feat: improve to loads all maps in custom folder (#988)
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Update to load all maps in custom maps folder instead of only the one specified. Loads maximum 50 custom maps. Removed old configuration and kept the toggle for loading custom maps or not. Added house, monster and npc XML files to gitignore to avoid pushing these if not intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to load all maps in custom maps folder instead of only the one specified. Loads maximum 50 custom maps.
Removed old configuration and kept the toggle for loading custom maps or not.
Added house, monster and npc xml files to gitignore to avoid pushing these if not intended.