fix: hireling conflicted with an existing npc #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestyotbr
approved these changes
Apr 1, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fixes creating a hireling with an existing NPC's name conflicting lines and sometimes even their look type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a hireling with an existing NPC's name was a bug, conflicting lines and sometimes even their look type.
Behaviour
Actual
Creating a hireling with the name of an existing NPC will conflict.
Expected
Now it's OK.
Fixes #522
Type of change