fix: ignore items missing id from assets (appearances.dat object) #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some scenarios, the assets editor bugs when saving items without a sprite and starts debugging, this way, we ignore the creation of items that do not have "object id" in the assets, preventing it from being able to debug due to an invalid item.
|
This Feature saved my life <3 @dudantas |
Rekoms90
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
I approve all of these changes.
What this does is amazing!
Its going to tell the server to block debugging tiles/items in assets thats not corresponding to an ACTUAL id from the items section.
What we/I could do now is safely start my server without getting anything to crash it.
Plus its gonna tell us the itemid thats causing a problem and the position of it.
This way we can keep all maps "clean" from bugs.
Extremely well done @dudantas !
|
Kudos, SonarCloud Quality Gate passed! |
majestyotbr
approved these changes
Mar 26, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
In some specific scenario, the assets editor bugs when saving items without a sprite and starts debug client, this way, we ignore the creation of items that do not have "object id" in the assets, preventing it from being able to debug due to an invalid item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some specific scenario, the assets editor bugs when saving items without a sprite and starts debug client, this way, we ignore the creation of items that do not have "object id" in the assets, preventing it from being able to debug due to an invalid item.
Behaviour
Actual
Creating items with no object, example of items:
168, 371, 858 and various others...
Expected
When creating the item without an ID, a message will appear stating that the item has no ID in the assets and the position of the item on the map, if you try to create it in game it will not work, it will return the message:
Type of change
How Has This Been Tested
Try to create an item without a sprite, and you will get the error mentioned in the print above, I put some example IDs for testing.
It will also inform the distro if the map has invalid items.