-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: familiar nil storage and others familiar bugs #947
Conversation
Kudos, SonarCloud Quality Gate passed! |
This is happening because of your mistake, apparently your datapack is missing some previous commit, just remove the "Global." |
• Fixed pointing to invalid storages, which makes the familiar tense completely wrong. • It was also fixed the creation of several summons when dying, because the list of cooldowns of the spells was cleared, allowing to summon a new one. (Which was also true for other spells) • Created a tag in config.lua for the duration of the familiar/spell Where the total value will be divided by two Example, familiarTime = 30 (will be divided by two, familiar time will be 15 minutes and spell cooldown 30) • Summon familiar spell is not more agressive spell (can be used in protection zone)
Description
• Fixed pointing to invalid storages, which makes the familiar tense completely wrong.
• It was also fixed the creation of several summons when dying, because the list of cooldowns of the spells was cleared, allowing to summon a new one. (Which was also true for other spells)
• Created a tag in config.lua for the duration of the familiar/spell
Where the total value will be divided by two
Example, familiarTime = 30 (will be divided by two, familiar time will be 15 minutes and spell cooldown 30)
• Summon familiar spell is not more agressive spell (can be used in protection zone)
Behaviour
Actual
Time appear buged on look and familiar not disappear.
Expected
Time is normal and familiar disappear.
Type of change