Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add "isRemoved" creature check for avoid memory freed #938

Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix: add "isRemoved" creature check for avoid memory freed #938

merged 1 commit into from
Mar 23, 2023

Conversation

travisani
Copy link
Contributor

@travisani travisani commented Mar 20, 2023 •
edited
Loading

Fix missing feature on script.
Need test.

By
@Ramon-bernado

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.8% 2.8% Duplication

dudantas
dudantas requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain better? preferably, follow the pull request form, how to test, what fixes, current and expected behavior... etc, this will help in the review.
the way it is it's hard to understand what exactly this fixes.

@travisani
Copy link
Contributor Author

Mesma lógica da linha 646 do protocolgame.cpp
if (!player || player->isRemoved() || player->getHealth() <= 0) {;

ver #23

@dudantas dudantas changed the title Fix Missing Creature Removal Check fix: add "isRemoved" creature check for avoid memory freed Mar 21, 2023
@dudantas dudantas merged commit 70e253f into opentibiabr:main Mar 23, 2023
luan pushed a commit that referenced this pull request Jul 11, 2023
@Solkrasm
fix: add "isRemoved" creature check for avoid memory use after freed (#…
4e79a46 
…938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@travisani @dudantas @Solkrasm