fix: powerful imbuement price #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placing it right so it will get the values correctly The way it is now its giving the wrong values for price and protection price it reads price from xml as protection price and vice versa the way it is now, only the powerful is correct due the price being set 'incorrectly'
correcting the last option (powerful) to its correct value.
|
Kudos, SonarCloud Quality Gate passed!
|
dudantas
reviewed
Mar 10, 2023
majestyotbr
approved these changes
Mar 15, 2023
dudantas
approved these changes
Mar 15, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Imbuements are being charged incorrectly, found it wasn't a bad config in Lua file (only), running the way it is, the only correct value is for powerful but just cuz it's misconfigured price and protectionPrice were wrongly placed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Imbuements are being charged incorrectly, found it wasn't a bad config in Lua file (only), running the way it is, the only correct value is for powerful but just cuz it's misconfigured price and protectionPrice were wrongly placed.
Behavior
When going to imbue an equipment, the basic and intricate options are asking for an incorrect amount
basic as example, it should be 5k to imbue and 10k to rise the odds
even though the file is right configured
the powerful option is configured wrongly but due the way the code is right now, you'll get the right value in game.
Expected
Considering the information
If going for the basic imbue you should be asked to pay 5k and 10k for rising the odds to 100%
intricate should ask 25k and 30k for rising the odds
(powerful is showing the correct value but again, its configured wrongly as you cans ee the price and protectionPrice set)
Fixes
placing price, protectionPrice in the right place and fixing the values for it will fix it.
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Logging to the game and trying to imbue an item and being sure to be charged the correct amount of gold
Before imbuing (plain value 100k)
after imbuing (you can see that i was charged correctly, 100k)
Test Configuration:
Checklist