fix: training with distance/missile item, advancing club skill

[elsongabriel]

Description

When training distance, the club skill was advancing. If you logout and login, the skills are adjusted.

Behaviour

Actual

Training distance, club skill advances.

Expected

Training distance, distance skill advances.

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

Test Configuration:

• Server Version: 12.91
• Client: Canary
• Operating System: Ubuntu 22.04

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[passok]

This solved it for me, but it is necessary to be careful that no player has logged out with the club skill in place in the distance, otherwise it will fix the value of the skill upgraded to club