Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove old XML npcs parameter #835

Merged
merged 6 commits into from
Feb 21, 2023
Merged

fix: remove old XML npcs parameter #835

merged 6 commits into from
Feb 21, 2023

Conversation

FeTads
Copy link
Contributor

@FeTads FeTads commented Feb 2, 2023

npc = Npc(creature) < não é necessário pois buga o npcHandler:Say tentando pegar o uid do NPC

npc = Npc(creature) < não é necessário pois buga o npcHandler:Say tentando pegar o uid do NPC
@omarcopires
Copy link
Contributor

If not needed, just remove the line. Remember to use the default pull request template, and also add a more descriptive name.

Copy link
Contributor

@elsongabriel elsongabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tem algo errado ainda.. mesmo removendo essa linha, e a linha 245 que estava repetida
npcHandler:setTopic(playerId, 5)
continua dando erro:

image

@murilo09 murilo09 changed the title Update lardoc_bashsmite.lua fix: lardoc_bashsmite.lua Feb 4, 2023
@murilo09 murilo09 marked this pull request as draft February 4, 2023 04:18
@dudantas
Copy link
Member

tem algo errado ainda.. mesmo removendo essa linha, e a linha 245 que estava repetida npcHandler:setTopic(playerId, 5) continua dando erro:

image

Como reproduzir o problema? Assim fica mais fácil de testar.

@elsongabriel
Copy link
Contributor

elsongabriel commented Feb 13, 2023

tem algo errado ainda.. mesmo removendo essa linha, e a linha 245 que estava repetida npcHandler:setTopic(playerId, 5) continua dando erro:
image

Como reproduzir o problema? Assim fica mais fácil de testar.

opa. desculpa a demora..
para reproduzir o erro, bastava falar com o npc, e dizer "status".
mas parece que funcionou. acho que era preciso fazer algum reload no servidor.

11:31:12 Lardoc Bashsmite: Since you are obviously not one of my relatives who pays me a long overdue visit, we should get work right away. We'll see if you can prove your worth to our alliance.
11:31:18 GOD Elsiin [1000]: status
11:31:20 Lardoc Bashsmite: So you want to know what we all think about your deeds? What leader's opinion are you interested in, the gnomes (Gnomus), the dwarves (Klom Stonecutter) or the scouts (Lardoc Bashsmite)?
11:31:23 GOD Elsiin [1000]: gnomes
11:31:24 Lardoc Bashsmite: The gnomes are still in need of your help, member of Bigfoot's Brigade. Prove your worth by answering their calls! (10/10)
11:31:25 GOD Elsiin [1000]: dwarves
11:31:26 Lardoc Bashsmite: The dwarves are still in need of your help, member of Bigfoot's Brigade. Prove your worth by answering their calls! (10/10)
11:31:27 GOD Elsiin [1000]: scouts
11:31:28 Lardoc Bashsmite: The scouts are still in need of your help, member of Bigfoot's Brigade. Prove your worth by answering their calls! (10/10)

Copy link
Contributor

@elsongabriel elsongabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok for me.

@dudantas dudantas changed the title fix: lardoc_bashsmite.lua fix: remove old parameter from npc Lardoc Bashsmite Feb 21, 2023
@dudantas dudantas marked this pull request as ready for review February 21, 2023 04:17
@dudantas dudantas changed the title fix: remove old parameter from npc Lardoc Bashsmite fix: remove old XML npcs parameter Feb 21, 2023
Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se não se importa... Tive a liberdade de aproveitar o seu pull request para corrigir o problema em outros npcs. Obrigado pela contribuição!

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
4.0% 4.0% Duplication

@dudantas dudantas merged commit 0187c86 into opentibiabr:main Feb 21, 2023
beats-dh pushed a commit to beats-dh/canary that referenced this pull request Feb 26, 2023
Some parameters left over from the old NPCs system in XML, removed and now the NPCs will work.
luan pushed a commit that referenced this pull request Jul 11, 2023
Some parameters left over from the old NPCs system in XML, removed and now the NPCs will work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants