feat: fear condition #542

bosmak · 2022-10-07T00:49:59Z

Description

Implement fear condition.

Type of change

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I checked the PR checks reports
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works

src/creatures/monsters/monsters.cpp

dudantas · 2022-10-07T00:58:04Z

Your pull request looks great, I approved the execution of the checks. I'll take a closer look later, but from what I've seen, everything seems ok.

sonarqubecloud · 2022-10-07T01:35:56Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
1 Security Hotspot
954 Code Smells

0.0% Coverage
0.0% Duplication

guispiller

Thank you, excellent PR!
Tested here, feared condition working fine restricting for party members, but still have some issues/restrictions for the condition itself, i'll point here:

Fear condition when activated, should remain for 6 seconds;
After being feared, when the condition finishes, you should have 10 seconds "cooldown" until you can get feared again;
When feared, you should not be able to use any spell, nor equip amulets/rings (at the pr sometimes you can use spell, and can equip items anytime)

dudantas · 2022-11-09T03:24:29Z

Thank you, excellent PR! Tested here, feared condition working fine restricting for party members, but still have some issues/restrictions for the condition itself, i'll point here:

Fear condition when activated, should remain for 6 seconds;

After being feared, when the condition finishes, you should have 10 seconds "cooldown" until you can get feared again;

When feared, you should not be able to use any spell, nor equip amulets/rings (at the pr sometimes you can use spell, and can equip items anytime)

I'll add the pull as a draft until the author decides to analyse it and, if necessary, fix the problems.

bosmak · 2022-11-09T13:58:31Z

Sorry for the delay, I have been stuck on some work-related topics.

I will try to work on it this week!

bosmak · 2022-11-14T01:31:07Z

@dudantas
I tried to remove the XML function, but it seems more code is attached, so I left it as is.

@guispiller
I couldn't reproduce using a spell under the fear condition.
Besides that, I adjusted the default duration to 6 seconds, Fixed that it was possible to change the equipment using the hotkeys, and finally added the cooldown for 10 seconds after being feared.

Could you test again?

For other contributors looking to test, just add the following attack to a monster

{name ="fear", interval = 2000, chance = 100, range=7, effect=CONST_ME_MAGIC_RED, target=true}

…llCheck function. Akk recommended this function to ensure no spell can be casted.

tutbarao · 2022-11-14T06:27:21Z

Tested! Functional!

jlcvp

Looking great, just a few suggestions

src/creatures/combat/combat.cpp

src/creatures/combat/condition.cpp

src/creatures/players/player.h

src/map/map.cpp

… in a party

paczielny · 2023-02-25T01:10:49Z

Severity Code Description Project File Line Suppression State
Error C3668 'ConditionFeared::executeCondition': method with override specifier 'override' did not override any base class methods

when try build :/

dudantas · 2023-02-25T02:16:11Z

Severity Code Description Project File Line Suppression State Error C3668 'ConditionFeared::executeCondition': method with override specifier 'override' did not override any base class methods

when try build :/

you must be using some mixture of prs or something, because the compilation checks are passing normally

paczielny · 2023-02-26T07:00:20Z

Severity Code Description Project File Line Suppression State Error C3668 'ConditionFeared::executeCondition': method with override specifier 'override' did not override any base class methods
when try build :/

you must be using some mixture of prs or something, because the compilation checks are passing normally

maybe version? 13.11

mohuga · 2023-02-27T06:34:04Z

character dont walk after feared, just stuck! but conditions of heal, time, etc still working correctly

dudantas · 2023-02-27T13:47:16Z

Severity Code Description Project File Line Suppression State Error C3668 'ConditionFeared::executeCondition': method with override specifier 'override' did not override any base class methods
when try build :/

you must be using some mixture of prs or something, because the compilation checks are passing normally

maybe version? 13.11

You need to test on the pull request branch only. The error you have is not related to the pull request itself, but its implementation.

elsongabriel · 2023-02-27T14:53:26Z

Severity Code Description Project File Line Suppression State Error C3668 'ConditionFeared::executeCondition': method with override specifier 'override' did not override any base class methods
when try build :/

you must be using some mixture of prs or something, because the compilation checks are passing normally

maybe version? 13.11

You need to test on the pull request branch only. The error you have is not related to the pull request itself, but its implementation.

I merged 3 branches.. this (fear_condition), test (client 13.11), and missing_bosses, it works!
we have to pay attention when merging with PR client 13, to use the functions with int64_t parameters.
@paczielny

github-actions · 2023-04-02T02:14:40Z

This PR is stale because it has been open 45 days with no activity.

dudantas · 2023-04-26T05:34:36Z

Severity Code Description Project File Line Suppression State Error C3668 'ConditionFeared::executeCondition': method with override specifier 'override' did not override any base class methods
when try build :/

you must be using some mixture of prs or something, because the compilation checks are passing normally

maybe version? 13.11

You need to test on the pull request branch only. The error you have is not related to the pull request itself, but its implementation.

I merged 3 branches.. this (fear_condition), test (client 13.11), and missing_bosses, it works! we have to pay attention when merging with PR client 13, to use the functions with int64_t parameters. @paczielny

Do you consider that the system is ok to be merged? Now we no longer have the changes to int64_t, which should make it easier for the system to implement.

paczielny · 2023-05-03T20:46:14Z

how add fear condition in attack of monsters?

paczielny · 2023-05-04T02:52:03Z

how add fear condition in attack of monsters?

nevermind

paczielny · 2023-05-10T23:34:28Z

compiled in 13.16

paczielny · 2023-05-10T23:35:23Z

dudantas · 2023-05-11T12:07:20Z

compiled in 13.16

Please, test again with my last commit. 11892d6

paczielny · 2023-05-11T15:22:19Z

compiled in 13.16

Please, test again with my last commit. 11892d6

working perfectly! thanks @dudantas

…g and reduce complexity

src/creatures/combat/combat.cpp

sonarqubecloud · 2023-05-20T15:46:11Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

0.0% Coverage
3.6% Duplication

The Fear Condition is a status condition that makes the affected creature lose control of their movements for a short period of time. During this period, the affected creature randomly moves around in various directions, unable to perform any other actions. This condition is usually brought about by certain spells or monster effects.

implement fear condition

71f4377

github-actions bot added the Area: Source label Oct 7, 2022

dudantas reviewed Oct 7, 2022

View reviewed changes

src/creatures/monsters/monsters.cpp Outdated Show resolved Hide resolved

guispiller reviewed Oct 12, 2022

View reviewed changes

Merge branch 'main' into fear_condition

079d3fa

dudantas marked this pull request as draft November 9, 2022 03:24

bosmak added 5 commits November 13, 2022 18:19

Merge branch 'main' into fear_condition

31e57e5

chore: change log level on fear checks

7bbdc92

fix: fear condition duration to 6 seconds

9e7463f

feat: feared players can't change equipaments

6ab0c60

feat: add a cooldown after a player is feared

255c570

bosmak marked this pull request as ready for review November 14, 2022 01:31

bosmak added 2 commits November 14, 2022 00:05

chore: add a second check if feared when casting a spell on playerSpe…

8c75eb5

…llCheck function. Akk recommended this function to ensure no spell can be casted.

fix: some sonar alerts

2045c27

jlcvp reviewed Nov 14, 2022

View reviewed changes

bosmak added 7 commits November 15, 2022 16:34

fix: wrong return on ConditionFear::isStuck

b594376

fix: omit parameters on setImmuneFear and isImmuneFear functions

741b41b

fix: fear being applied to more players than it should when player is…

409a5f6

… in a party

fix: stop randomizing dirList on ConditionFeared

ece5f24

fix: codacy issues

49c4781

fix: try to fix some sonar alerts

c784ff6

chore: improve format

24516cb

bosmak requested review from guispiller and removed request for guispiller November 17, 2022 20:28

github-actions bot added Stale No activity and removed Stale No activity labels Apr 2, 2023

Merge branch 'main' into fear_condition

d811705

Merge branch 'main' into fear_condition

26062fb

fix: register condition feared

11892d6

elsongabriel approved these changes May 15, 2023

View reviewed changes

dudantas added 2 commits May 20, 2023 11:34

fix: resolve sonar checks and improve some codes

002670b

improve: extract code in a separated function for better understandin…

f11dd10

…g and reduce complexity

dudantas approved these changes May 20, 2023

View reviewed changes

majestyotbr approved these changes May 20, 2023

View reviewed changes

dudantas merged commit 801c7bc into opentibiabr:main May 20, 2023

bosmak deleted the fear_condition branch May 21, 2023 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fear condition #542

feat: fear condition #542

bosmak commented Oct 7, 2022 •

edited

Loading

dudantas commented Oct 7, 2022 •

edited

Loading

sonarqubecloud bot commented Oct 7, 2022

guispiller left a comment

dudantas commented Nov 9, 2022

bosmak commented Nov 9, 2022 •

edited

Loading

bosmak commented Nov 14, 2022 •

edited

Loading

tutbarao commented Nov 14, 2022

jlcvp left a comment

paczielny commented Feb 25, 2023

dudantas commented Feb 25, 2023

paczielny commented Feb 26, 2023

mohuga commented Feb 27, 2023

dudantas commented Feb 27, 2023

elsongabriel commented Feb 27, 2023 •

edited

Loading

github-actions bot commented Apr 2, 2023

dudantas commented Apr 26, 2023

paczielny commented May 3, 2023

paczielny commented May 4, 2023

paczielny commented May 10, 2023

paczielny commented May 10, 2023

dudantas commented May 11, 2023

paczielny commented May 11, 2023

sonarqubecloud bot commented May 20, 2023

feat: fear condition #542

feat: fear condition #542

Conversation

bosmak commented Oct 7, 2022 • edited Loading

Description

Type of change

Checklist

dudantas commented Oct 7, 2022 • edited Loading

sonarqubecloud bot commented Oct 7, 2022

guispiller left a comment

Choose a reason for hiding this comment

dudantas commented Nov 9, 2022

bosmak commented Nov 9, 2022 • edited Loading

bosmak commented Nov 14, 2022 • edited Loading

tutbarao commented Nov 14, 2022

jlcvp left a comment

Choose a reason for hiding this comment

paczielny commented Feb 25, 2023

dudantas commented Feb 25, 2023

paczielny commented Feb 26, 2023

mohuga commented Feb 27, 2023

dudantas commented Feb 27, 2023

elsongabriel commented Feb 27, 2023 • edited Loading

github-actions bot commented Apr 2, 2023

dudantas commented Apr 26, 2023

paczielny commented May 3, 2023

paczielny commented May 4, 2023

paczielny commented May 10, 2023

paczielny commented May 10, 2023

dudantas commented May 11, 2023

paczielny commented May 11, 2023

sonarqubecloud bot commented May 20, 2023

bosmak commented Oct 7, 2022 •

edited

Loading

dudantas commented Oct 7, 2022 •

edited

Loading

bosmak commented Nov 9, 2022 •

edited

Loading

bosmak commented Nov 14, 2022 •

edited

Loading

elsongabriel commented Feb 27, 2023 •

edited

Loading