feat: specialized magic level, cleave and perfect shot (systems) #529

dudantas · 2022-09-22T17:07:57Z

Need testing

Thanks for help to @hyresu
Old pr: #143

Co-Authored-By: Rick <[email protected]> Co-Authored-By: Marcos <[email protected]>

Co-Authored-By: Rick <[email protected]>

Co-Authored-By: Marcos <[email protected]>

Co-Authored-By: Majesty <[email protected]>

…to "reflectDamage"

If something doesn't work contact me on the discord server to fix it

src/items/weapons/weapons.cpp

src/game/game.cpp

dudantas · 2023-07-13T02:33:04Z

@jacksonie fixed, thanks!

jacksonie · 2023-07-13T02:58:01Z

@dudantas
I found a new crash, can you test it?
To try to reproduce you must equip a "Royal Star" and any sheild (in my case I used the "Mastermind Shield"), then attack a creature.

it might just be happening in my test environment, so I want you to test.

luan · 2023-07-13T03:16:36Z

@dudantas I found a new crash, can you test it? To try to reproduce you must equip a "Royal Star" and any sheild (in my case I used the "Mastermind Shield"), then attack a creature.

it might just be happening in my test environment, so I want you to test.

I just tested this scenario but no crash here.

jacksonie · 2023-07-13T03:31:04Z

@dudantas I found a new crash, can you test it? To try to reproduce you must equip a "Royal Star" and any sheild (in my case I used the "Mastermind Shield"), then attack a creature.
it might just be happening in my test environment, so I want you to test.

I just tested this scenario but no crash here.

nice, thanks

src/creatures/combat/condition.cpp

src/creatures/creature.cpp

src/server/network/protocol/protocolgame.cpp

src/creatures/creatures_definitions.hpp

src/server/network/protocol/protocolgame.cpp

Co-authored-by: Luan Santos <[email protected]>

src/lua/functions/creatures/monster/monster_type_functions.cpp

… into mechanics-12.72

sonarqubecloud · 2023-07-18T09:02:21Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
140 Code Smells

0.0% Coverage
13.6% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

dudantas and others added 30 commits October 17, 2021 15:18

Add support for 12.72 tibia protocol

31dcbcf

Co-Authored-By: Rick <[email protected]> Co-Authored-By: Marcos <[email protected]>

Remove unused code and improve perfect shoot range

8120650

Co-Authored-By: Rick <[email protected]>

Remove unused byte

65db4a1

Co-Authored-By: Rick <[email protected]>

Add items.otb for 12.72

7b0aa72

Add creature icons

d0a8439

Co-Authored-By: Marcos <[email protected]>

Refacor items modifiers code

620bfdf

Remove writeToOutputBuffer

207bc7c

Register missing items

fdf84f6

Merge branch 'master' into protocol-12.72

db8abea

12.72 with mechanic

7217421

Fix attribute name

e7751bb

Fix items.xml

078a9ed

Register new weapons

18be1c3

Co-Authored-By: Majesty <[email protected]>

Fix somes wrong items.xml tags

e233259

Register movements

228f72c

Fix bug in the reflectDamage description and set from "reflectMelee" …

1a01fe1

…to "reflectDamage"

Remove whitespaces

2ee03fb

Fix tags bug and wrong id

5014b28

Fix market description items bug

a68a47b

Change protocol version for 12.72 in config.lua.dist

50be5ed

Fix value of range and hit chance

e292b79

Add missing bytes from sendMarketDetail

943f557

Fix int size

a907bc4

Reworked some mechanics

c1ab9ba

If something doesn't work contact me on the discord server to fix it

COMBAT_NONE crash fix & crash on combat without attacker

7e7f692

Fix duplicate "(" for cleave damage in server log

59acb0e

Fix for compiling

4bb82ec

Fix for compiling 2

0c50b5b

Using charges on apply and charm parry moved & fixed minor details

09e86e2

Update weapons.cpp

9bc0f4b

jacksonie reviewed Jul 13, 2023

View reviewed changes

src/items/weapons/weapons.cpp Outdated Show resolved Hide resolved

jacksonie reviewed Jul 13, 2023

View reviewed changes

src/game/game.cpp Outdated Show resolved Hide resolved

fix: quiver nullpointer

a6e4211

Code format - (Clang-format)

b9a9b54

luan reviewed Jul 14, 2023

View reviewed changes

dudantas and others added 5 commits July 14, 2023 11:23

Update src/creatures/combat/condition.cpp

d365a1d

Co-authored-by: Luan Santos <[email protected]>

Update src/creatures/combat/condition.cpp

331e4ea

Co-authored-by: Luan Santos <[email protected]>

Update src/creatures/creature.cpp

1e042e1

Co-authored-by: Luan Santos <[email protected]>

Update src/server/network/protocol/protocolgame.cpp

ac244ab

Co-authored-by: Luan Santos <[email protected]>

Update src/creatures/creature.cpp

6436a1d

Co-authored-by: Luan Santos <[email protected]>

luan reviewed Jul 14, 2023

View reviewed changes

src/lua/functions/creatures/monster/monster_type_functions.cpp Outdated Show resolved Hide resolved

luan and others added 10 commits July 14, 2023 14:24

Update src/lua/functions/creatures/monster/monster_type_functions.cpp

3695a54

Merge branch 'main' into mechanics-12.72

56db078

fix: imbuement reduction to cyclopedia and small condition refactor

6ecb15c

Code format - (Clang-format)

e4bb554

remove duplicated code

fcce0f0

Merge branch 'mechanics-12.72' of https://github.com/opentibiabr/canary…

5a8ad0b

… into mechanics-12.72

fix: add log

3e8ff65

fix: remove inventory items from this pr

9419b8f

fix: typo and remove unused variable

5b249bf

fix: final fixes

128b143

luan approved these changes Jul 18, 2023

View reviewed changes

fix: checks

1a2bd5d

dudantas merged commit 9f40ee0 into main Jul 18, 2023

majestyotbr deleted the mechanics-12.72 branch July 26, 2023 22:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: specialized magic level, cleave and perfect shot (systems) #529

feat: specialized magic level, cleave and perfect shot (systems) #529

dudantas commented Sep 22, 2022 •

edited

Loading

dudantas commented Jul 13, 2023

jacksonie commented Jul 13, 2023 •

edited

Loading

luan commented Jul 13, 2023

jacksonie commented Jul 13, 2023

sonarqubecloud bot commented Jul 18, 2023

feat: specialized magic level, cleave and perfect shot (systems) #529

feat: specialized magic level, cleave and perfect shot (systems) #529

Conversation

dudantas commented Sep 22, 2022 • edited Loading

dudantas commented Jul 13, 2023

jacksonie commented Jul 13, 2023 • edited Loading

luan commented Jul 13, 2023

jacksonie commented Jul 13, 2023

sonarqubecloud bot commented Jul 18, 2023

dudantas commented Sep 22, 2022 •

edited

Loading

jacksonie commented Jul 13, 2023 •

edited

Loading