Remove definition of "ITEM_TYPE_MAGICFIELD" from items.xml "field" tag

[dudantas]

Description

When using a fire field rune (client id 3188), for example, on top of a campfire (client id 1999), the campfire disappeared.
The problem was because the "field" tag was setting the itemtype as "ITEM_TYPE_MAGICFIELD", which caused the two items to become the same type and conflict in sqm, removing the previous one.
The correct thing is to use the tag "type" to define the type of the item:

<attribute key="type" value="magicfield"/>

Behaviour

Actual

Expected

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication