Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert data-canary tools to client id #406

Merged
merged 16 commits into from
Mar 16, 2023
Merged

fix: convert data-canary tools to client id #406

merged 16 commits into from
Mar 16, 2023

Conversation

Aerwix
Copy link
Contributor

@Aerwix Aerwix commented Jun 4, 2022

All this items were bugged, idk why nobody reported it. I took from Global and pushing to Canary.

Machete
Shovel
Pick
Tool Gears

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Jul 5, 2022
@github-actions github-actions bot removed the Stale No activity label Nov 3, 2022
@beats-dh beats-dh marked this pull request as draft November 27, 2022 20:10
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Dec 28, 2022
@dudantas
Copy link
Member

@Aerwix can you update the pr, please?

@Aerwix
Copy link
Contributor Author

Aerwix commented Feb 20, 2023

I will check it tomorrow in the morning, idk if this bug still exist but if it does, consider it done. Thanks

@Aerwix Aerwix closed this Feb 20, 2023
Aerwix added 4 commits February 20, 2023 14:20
Update register_actions.lua
95b41d1 
Patch # 1
Fix: Shovel giving wrong item on sand.
c7496d7 
**Scarab Coin**
Change serverId for clientId
Fix Scythe Wheat
407694e
Fix Scickle
87d0524 
Adding correct client Ids
@Aerwix
Copy link
Contributor Author

Aerwix commented Feb 20, 2023

The other PR was totally a mess, I tried to fix mostly things. Eventually gonna appear some stuff, but I will be sharp to fix it.
@dudantas

@Aerwix Aerwix reopened this Feb 22, 2023
@Aerwix Aerwix marked this pull request as ready for review February 22, 2023 21:20
@Aerwix
Copy link
Contributor Author

Aerwix commented Feb 22, 2023 •
edited
Loading

After all, I changed some IDs from ServerId to ClientId.

I still having some issues with toolgear that isn't working correctly. I believe this return function is causing issues but being honest, I checked the global file and it works fine there . Anyway I don't have much time for now but I'll check it later.
image

Meanwhile you can push this fix @dudantas

@github-actions github-actions bot removed the Stale No activity label Feb 23, 2023
@dudantas dudantas changed the title Sync-Fix-Tools fix: data-canary tools to client id Mar 16, 2023
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@dudantas dudantas merged commit ec21cc9 into opentibiabr:main Mar 16, 2023
@dudantas dudantas changed the title fix: data-canary tools to client id fix: convert data-canary tools to client id Mar 16, 2023
@majestyotbr majestyotbr mentioned this pull request Mar 22, 2023
Closed
5 tasks
@majestyotbr majestyotbr linked an issue Mar 22, 2023 that may be closed by this pull request
Tools aren't working properly. #381
Closed
5 tasks
luan pushed a commit that referenced this pull request Jul 11, 2023
@Aerwix
fix: convert data-canary tools to client id (#406)
b0ebeb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

Assignees
No one assigned
Labels
Area: Datapack Canary
Projects
Canary - Release 3.5
Status: PRs Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tools aren't working properly.
3 participants
@Aerwix @dudantas @majestyotbr