Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gamestore cpp #2834

Open
wants to merge 100 commits into
base: main
Choose a base branch
from
Open

feat: gamestore cpp #2834

wants to merge 100 commits into from

Conversation

murilo09
Copy link
Contributor

@murilo09 murilo09 commented Aug 20, 2024

Description

Moving Gamestore to CPP

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a list of the missing contents.

  • Store only accepting transferable tibia coins as payment
  • Bundle
  • Hirelings
  • Name change
  • XP Boost
  • Check if Vip System activated
  • Integration with Cyclopedia info and history
  • Change string format to fmt

src/io/functions/iologindata_load_player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
src/io/functions/iologindata_save_player.cpp Outdated Show resolved Hide resolved
Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave some suggestions, but I'll commit the corrections now.

src/account/account_repository.hpp Outdated Show resolved Hide resolved
src/account/account_repository_db.cpp Outdated Show resolved Hide resolved
src/account/account_repository_db.hpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.hpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
@murilo09 murilo09 marked this pull request as ready for review November 3, 2024 05:43
Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Dec 6, 2024
@murilo09 murilo09 removed the Stale No activity label Dec 31, 2024
@powrogames
Copy link

I would suggest making possibility of accept both coins (transferable and non-transferable), It was requested many times so maybe it is good idea to make CoinType.Both and access 2 of coins kind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants