feat: missing configuration warning #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pedro Cruz <[email protected]>
phacUFPE
approved these changes
Jun 24, 2024
majestyotbr
approved these changes
Jun 25, 2024
elsongabriel
suggested changes
Jun 25, 2024
elsongabriel
reviewed
Jul 2, 2024
elsongabriel
approved these changes
Jul 10, 2024
majestyotbr
force-pushed
the
config-warnin
branch
from
26eb3b9 to
2249a83
Compare
pasturryx
pushed a commit
to pasturryx/canary1
that referenced
this pull request
Aug 1, 2024
When a configuration is missing in config.lua, you will get a warning in console. You can ignore the warning and, this way, the default value will be used. With the warning, you dont need to conflict your config.lua with configmanager.
pasturryx
pushed a commit
to pasturryx/canary1
that referenced
this pull request
Aug 1, 2024
When a configuration is missing in config.lua, you will get a warning in console. You can ignore the warning and, this way, the default value will be used. With the warning, you dont need to conflict your config.lua with configmanager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a configuration is missing in config.lua, you will get a warning in console.
You can ignore the warning and, this way, the default value will be used.
With the warning, you dont need to conflict your config.lua with configmanager.
Behaviour
Actual
If a configuration is missing, the default value will be used and you will not get a warning in console.
Expected
If a configuration is missing, the default value will be used BUT you will receive a warning in console.
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Delete a configuration string from config.lua and you will receive a warning in console when server starts.