improve: ConfigManager better functionality/code clarity/maintainability #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It avoids code repetition and facilitates maintainability, as now the enums will be registered in lua automatically.
dudantas
approved these changes
Nov 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp of the ConfigManager component, aimed at not only improving functionality and code clarity but also enhancing long-term maintainability.
Changes Made:
• Extensively restructured the ConfigManager to optimize functionality, making it more robust and versatile.
• Focused on enhancing code clarity, making the codebase more comprehensible and maintainable for future contributors.
• Introduced magic enums to streamline enum registration for the Lua interface, improving maintainability and reducing potential issues.
These modifications will not only benefit the project's current state but also set the stage for easier maintenance and further development. This demonstrates our commitment to maintaining a high-quality with a codebase that is both efficient and sustainable.