Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: adjusting autoloot as it is activated by default (-1) #1767

Merged
merged 2 commits into from
Nov 4, 2023
Merged

improve: adjusting autoloot as it is activated by default (-1) #1767

merged 2 commits into from
Nov 4, 2023

Conversation

luanluciano93
Copy link
Contributor

No description provided.

@dudantas
Copy link
Member

dudantas commented Nov 4, 2023

What does this improve?

@luanluciano93
Copy link
Contributor Author

luanluciano93 commented Nov 4, 2023 •
edited
Loading

Por padrão o valor vem como -1 das storages ...
Pela leitura nas sources, o sistema é ativado por padrão, e apenas desativado se eu setar 0.
Ao meu ver é interessante o autoloot vir desativado por padrão e ativado caso seja setado 1 em seu valor.
(Entre o 0 e -1 para desativa-lo, é mais interessante o -1, pois não acumula o valores no banco de dados)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.4% 0.4% Duplication

@dudantas dudantas merged commit 961db0c into opentibiabr:main Nov 4, 2023
marcusvcj pushed a commit to marcusvcj/canary that referenced this pull request Nov 4, 2023
@luanluciano93 @marcusvcj
fix: adjust autoloot as it is activated by default (-1) (opentibiabr#…
4de27d5 
…1767)
@luanluciano93 luanluciano93 deleted the fixAutoloot branch November 15, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
Area: Datapack Core Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luanluciano93 @dudantas