improve: use modern implementations to manage threads #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luan
approved these changes
Oct 28, 2023
dudantas
approved these changes
Nov 2, 2023
|
Kudos, SonarCloud Quality Gate passed! |
marcusvcj
pushed a commit
to marcusvcj/canary
that referenced
this pull request
Nov 4, 2023
This updates the thread management constructs within the codebase. It shifts from using std::lock_guard to std::scoped_lock for managing mutexes, providing a more modern and safer scope-based locking mechanism. Additionally, it replaces std::condition_variable with std::atomic::wait, leveraging the more efficient and scalable waiting and notification system provided by atomics. Benefits: • std::scoped_lock is more flexible than std::lock_guard, allowing for handling multiple mutexes without the risk of deadlock. • std::atomic::wait introduces potential performance gains by utilizing a more lightweight synchronization mechanism compared to traditional condition variables. Impact: • These improvements are expected to enhance the safety and efficiency of concurrent operations. They modernize the codebase, aligning it with current best practices for C++ concurrency.
marcusvcj
pushed a commit
to marcusvcj/canary
that referenced
this pull request
Nov 20, 2023
This updates the thread management constructs within the codebase. It shifts from using std::lock_guard to std::scoped_lock for managing mutexes, providing a more modern and safer scope-based locking mechanism. Additionally, it replaces std::condition_variable with std::atomic::wait, leveraging the more efficient and scalable waiting and notification system provided by atomics. Benefits: • std::scoped_lock is more flexible than std::lock_guard, allowing for handling multiple mutexes without the risk of deadlock. • std::atomic::wait introduces potential performance gains by utilizing a more lightweight synchronization mechanism compared to traditional condition variables. Impact: • These improvements are expected to enhance the safety and efficiency of concurrent operations. They modernize the codebase, aligning it with current best practices for C++ concurrency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement: Modernized Thread Management
Description:
This pull request updates the thread management constructs within the codebase. It shifts from using
std::lock_guardtostd::scoped_lockfor managing mutexes, providing a more modern and safer scope-based locking mechanism. Additionally, it replacesstd::condition_variablewithstd::atomic::wait, leveraging the more efficient and scalable waiting and notification system provided by atomics.Benefits:
std::scoped_lockis more flexible thanstd::lock_guard, allowing for handling multiple mutexes without the risk of deadlock.std::atomic::waitintroduces potential performance gains by utilizing a more lightweight synchronization mechanism compared to traditional condition variables.Impact:
These improvements are expected to enhance the safety and efficiency of concurrent operations. They modernize the codebase, aligning it with current best practices for C++ concurrency.