Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some scripts #1741

Merged
merged 8 commits into from
Oct 26, 2023
Merged

fix: some scripts #1741

merged 8 commits into from
Oct 26, 2023

Conversation

elsongabriel
Copy link
Contributor

Description

  • Added 'RatmiralBlackwhiskersDeath' event to win outfit.
  • Fixed some typos.
  • Adjusted some validations.
  • Fixed dream_courts_lever.lua that was broke index.
  • Added validation to do not permit rookers players with bless.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Test Configuration:

  • Server Version: Canary 3.0
  • Client: Tibia 13.21
  • Operating System: Windows/Ubuntu

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@elsongabriel elsongabriel requested a review from luan October 24, 2023 17:23
elsongabriel and others added 8 commits October 25, 2023 15:14
@elsongabriel
Fixed some scripts.
b1803c5 
Added 'RatmiralBlackwhiskersDeath' event to win outfit.
Fixed some typos.
Adjusted some validations.
Fixed dream_courts_lever.lua that was broke index.
Added validation to do not permit rookers players with bless.
@github-actions @elsongabriel
Lua code format - (Stylua)
957d145
@elsongabriel
Fixed Trainer Machine bug, after reload scripts.
de108ea
@elsongabriel
redo check.
859c0b4
@elsongabriel
Fixed some bosses bug from (opentibiabr#1724).
e505d02 
Fixed boss_death checks and log.
@elsongabriel
Fixed gnomish_pesticide.lua.
f17f918
@elsongabriel
Fixed some bosses checks from (opentibiabr#1724).
042c35b
@elsongabriel
creating checks and validations (causing errors).
6138206
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 8233a24 into opentibiabr:main Oct 26, 2023
@elsongabriel elsongabriel mentioned this pull request Nov 6, 2023
Merged
8 tasks
dudantas pushed a commit that referenced this pull request Nov 13, 2023
@elsongabriel
fix: some scripts (#1784)
f7271db 
Continues fixing of #1741

• Created a function to check time in levers and changed with `creature:getStorageValue(config.storage) > os.time()`;
• Adjusted save_interval messages.
• Added check to show msg with payment information when traveling as free.
• Fixed loot to custodian.
• Fixed some typos.
• Adjusted reward talkaction, to check cap.
• Fixed adventurer's stone usage.
• Added messages when starting or stopping using exercise weapons.
• Fixed some events of bosses.
@elsongabriel elsongabriel mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luan luan luan approved these changes

@dudantas dudantas dudantas approved these changes

@Mirkaanks Mirkaanks Mirkaanks approved these changes

Assignees
No one assigned
Labels
Area: Datapack Core Area: Datapack Global Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elsongabriel @luan @dudantas @Mirkaanks