fix: house_lists version column in database with wrong type #1716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The column is defined with the type int, which receives a maximum value of 4.294.967.295. Therefore, it was showing an error when saving the database table. The solution I found was to change the type of the version column from INT to BIGINT.
Behaviour
Actual
Unable to save house lists.
Showing error in console: "Query: INSERT INTO
house_lists
(house_id
,listid
,list
,version
) VALUES ...."Expected
Normally saving the houses.
Fixes #issuenumber
Type of change
How Has This Been Tested
I've changed the type in database and run /save with GOD account. The save is now working as expected.
[2023-19-10 09:21:17.403] [info] The server will save all accounts within 60 seconds. You might lag or freeze for 5 seconds, please find a safe place.
[2023-19-10 09:22:17.409] [info] CLEAN: Removed 7 items from 7 tiles in 0 seconds
[2023-19-10 09:22:17.409] [info] Saving server...
[2023-19-10 09:22:18.126] [info] Saved house items in 0.454 seconds
[2023-19-10 09:22:18.205] [info] Server save complete. Next save in 1 hour!
Test Configuration:
Checklist