Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scoped KV, save KV to DB, boolean vals #1661

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix: scoped KV, save KV to DB, boolean vals #1661

merged 3 commits into from
Oct 3, 2023

Conversation

luan
Copy link
Contributor

@luan luan commented Oct 1, 2023

A previous PR optimizing saves ended up canceling out saves here. Also:

  • Fixed nested scopes (and added a unit test)
  • Added boolean as a possible type for the KV values
  • Simplified the logic inside KV by removing a lot of templates and made scopes lighter weight with a simpler hierarchy.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 3ef5307 into opentibiabr:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luan @dudantas @majestyotbr