feat: more robust zone handling #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrossi
approved these changes
Aug 28, 2023
dudantas
approved these changes
Aug 28, 2023
|
Kudos, SonarCloud Quality Gate passed! |
JasterDesu
pushed a commit
to JasterDesu/canary
that referenced
this pull request
Sep 16, 2023
This adds a lot of safety to how we handle Zones. Making it so dealing with the contents of a zone is never going to respond with creatures that have already been deleted. This also migrated the `bosslever.lua` to use zones, and deprectes the Spectators library. Zones are a more flexible way to achieve the same thing, and more. This should also fix a potential crazy with the removal of players from a bosslever room since that was previously done with an unsafe call to `addEvent`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lot of safety to how we handle Zones. Making it so dealing with the contents of a zone is never going to respond with creatures that have already been deleted.
This also migrated the
bosslever.luato use zones, and deprectes the Spectators library. Zones are a more flexible way to achieve the same thing, and more. This should also fix a potential crazy with the removal of players from a bosslever room since that was previously done with an unsafe call toaddEvent.