improve: move DI out of the pch #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrossi
force-pushed
the
lucas/move-container-out-pch
branch
3 times, most recently
from
5228b10 to
5d47dd5
Compare
lgrossi
force-pushed
the
lucas/move-container-out-pch
branch
8 times, most recently
from
ebc3d03 to
d3aa55d
Compare
Container DI will eventually have too much internal code, and it won't behave as a library but as a shared container. Thus, moving it out of pch will improve building and reduce chances of cross dependencies.
lgrossi
force-pushed
the
lucas/move-container-out-pch
branch
from
8d1d31b to
de8c1f6
Compare
lgrossi
force-pushed
the
lucas/move-container-out-pch
branch
from
a2c0371 to
f0c2622
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
elsongabriel
approved these changes
Aug 26, 2023
dudantas
approved these changes
Aug 26, 2023
|
Working! Solution: Cmake: |
luan
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container DI will eventually have too much internal code, and it won't behave as a library but as a shared container. Thus, moving it out of pch will improve building and reduce chances of cross dependencies.