Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: magma bubble full mechanics #1481

Merged
merged 1 commit into from
Aug 29, 2023
Merged

feat: magma bubble full mechanics #1481

merged 1 commit into from
Aug 29, 2023

Conversation

luan
Copy link
Contributor

@luan luan commented Aug 22, 2023

Video of the full mechanics (it's long, if you want to check it out i'd speed it up :P):
https://www.youtube.com/watch?v=JqUK-iGql1k

@luan
Copy link
Contributor Author

luan commented Aug 22, 2023

Code is complete and working well -- setting it to draft so I can get a video of the mechanics working as an example before I write the description.

@paczielny
Copy link

image

when try to compile

@luan
Copy link
Contributor Author

luan commented Aug 23, 2023

image

when try to compile

I'll look into this later tonight -- I think i missed something when I made the PR here

@luan luan marked this pull request as ready for review August 25, 2023 07:53
@luan
Copy link
Contributor Author

luan commented Aug 25, 2023

image

when try to compile

all fixed up and ready to review :)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
5.3% 5.3% Duplication

@luan luan merged commit e2400fe into opentibiabr:main Aug 29, 2023
@luan luan deleted the luan/magma-bubble branch August 29, 2023 18:14
JasterDesu pushed a commit to JasterDesu/canary that referenced this pull request Sep 16, 2023
Video of the full mechanics (it's long, if you want to check it out i'd
speed it up :P):
https://www.youtube.com/watch?v=JqUK-iGql1k
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants