Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: executioner throw chain #1479

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Conversation

jarrodpjohnston
Copy link
Contributor

@jarrodpjohnston jarrodpjohnston commented Aug 22, 2023

Description

Executioner's Throw is being migrated to cpp chain system. Fixes were made for WOD revelation perk for fetching Exec. Throw stages. Old Executioner's Throw (getSpectators()) allowed chaining through walls to additional targets.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Stage one Exec Throw, note cooldown for spell. Upgrade to stage two and note new cooldown.
  • Throw Exec Throw near mobs that are beyond walls.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
1.0% 1.0% Duplication

@dudantas
Copy link
Member

Thanks for your contribution!

Consider participating in our discord group: https://discord.com/invite/gvTj5sh9Mp

@dudantas dudantas merged commit 3a45a25 into opentibiabr:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants