refactor: simplify map file reading (removed tree nodes) #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
changed the title
Extract "FileStream" in a new file. Removed some includes and using forward declaration.
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
approved these changes
Aug 21, 2023
dudantas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map loading has been completely overhauled, resulting in a substantial improvement in read time by approximately 35~50%. The previous implementation was inefficiently allocating memory due to the 'tree' structure created by OTB::Loader. This update eliminates that issue, streamlining the memory usage and enhancing the overall performance of the map loading process.
The changes lead to a more straightforward and maintainable codebase, making it easier to understand and modify in the future. By removing unnecessary complexity, this refactor enhances the efficiency of the file reading process and aligns with best practices for clean and concise code.