improve: minor enhancements in utils functions #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrossi
force-pushed
the
lucas/minor-adjusts-to-get-direction
branch
from
27fc0ed to
a9bb2bd
Compare
dudantas
approved these changes
Aug 20, 2023
dudantas
changed the title
lgrossi
force-pushed
the
lucas/minor-adjusts-to-get-direction
branch
from
15e2b4a to
3aae4bc
Compare
luan
approved these changes
Aug 20, 2023
lgrossi
force-pushed
the
lucas/minor-adjusts-to-get-direction
branch
from
3aae4bc to
7c8d08f
Compare
lgrossi
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make some minor adjustements in utils functions, like some standardization and simplification.
The main goal is actually add tests to those functions while we do some adjustments, so that we can start adding tests to our code base.
O are not aiming to add unit test to every single class, but this is a nice way to start testing the unit test framework til we get confortable enough to have small flows as our "unit" instead of individual methods.