Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: tweaks in talkactions #1445

Merged
merged 7 commits into from
Aug 22, 2023
Merged

improve: tweaks in talkactions #1445

merged 7 commits into from
Aug 22, 2023

Conversation

luanluciano93
Copy link
Contributor

Description

adjusting variable positions and solving some errors.

Test Configuration:

  • Server Version: Canary Main
  • Client: 13.20
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

@luan luan changed the title improve: tweaks in talkactions. improve: tweaks in talkactions Aug 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

@dudantas dudantas merged commit 84527dc into opentibiabr:main Aug 22, 2023
@luanluciano93 luanluciano93 deleted the AjustTalkVariablePosition branch September 8, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luan luan luan approved these changes

@elsongabriel elsongabriel elsongabriel approved these changes

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
Area: Datapack Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luanluciano93 @luan @elsongabriel @dudantas