Fix backpacks positions on login

[omeranha]

Description

With this fix the backpacks in your inventory now maintain the the exact position in client on login
Thanks to Rick.

and now, with @gerotib help, the containers will be opened when happens an x-log or crash

opinions and code modernization are welcome and appreciate.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[gerotib]

Theres issue with this system (not pr) that containers are not getting opened after x-log/crash, when player is still in game so we only connect without loggin in again.

I fixed that by function similar to one from iologindata, maybe it could be made cleaner.

In player.h after:

void sendInventoryClientIds() {
			if (client) {
				client->sendInventoryClientIds();
			}
		}

add:
void openPlayerContainers();

In protocolgame.cpp into function
void ProtocolGame::connect(uint32_t playerId, OperatingSystem_t operatingSystem)
add:
player->openPlayerContainers();

In player.cpp add:

void Player::openPlayerContainers()
{
	std::vector<std::pair<uint8_t, Container*>> openContainersList;

	for (int32_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; i++) {
		Item* item = inventory[i];
		if (!item) {
			continue;
		}

		Container* itemContainer = item->getContainer();
		if (itemContainer) {
			uint8_t cid = item->getIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER);
			if (cid > 0) {
				openContainersList.emplace_back(std::make_pair(cid, itemContainer));
			}
			for (ContainerIterator it = itemContainer->iterator(); it.hasNext(); it.advance()) {
				Container* subContainer = (*it)->getContainer();
				if (subContainer) {
					uint8_t subcid = (*it)->getIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER);
					if (subcid > 0) {
						openContainersList.emplace_back(std::make_pair(subcid, subContainer));
					}
				}
			}
		}
	}

	std::sort(openContainersList.begin(), openContainersList.end(), [](const std::pair<uint8_t, Container*>& left, const std::pair<uint8_t, Container*>& right) {
		return left.first < right.first;
	});

	for (auto& it : openContainersList) {
		addContainer(it.first - 1, it.second);
		onSendContainer(it.second);
	}
}

[omeranha]

Theres issue with this system (not pr) that containers are not getting opened after x-log/crash, when player is still in game so we only connect without loggin in again.

I fixed that by function similar to one from iologindata, maybe it could be made cleaner.

In player.h after:

void sendInventoryClientIds() {
			if (client) {
				client->sendInventoryClientIds();
			}
		}

add: void openPlayerContainers();

In protocolgame.cpp into function void ProtocolGame::connect(uint32_t playerId, OperatingSystem_t operatingSystem) add: player->openPlayerContainers();

In player.cpp add:

void Player::openPlayerContainers()
{
	std::vector<std::pair<uint8_t, Container*>> openContainersList;

	for (int32_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; i++) {
		Item* item = inventory[i];
		if (!item) {
			continue;
		}

		Container* itemContainer = item->getContainer();
		if (itemContainer) {
			uint8_t cid = item->getIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER);
			if (cid > 0) {
				openContainersList.emplace_back(std::make_pair(cid, itemContainer));
			}
			for (ContainerIterator it = itemContainer->iterator(); it.hasNext(); it.advance()) {
				Container* subContainer = (*it)->getContainer();
				if (subContainer) {
					uint8_t subcid = (*it)->getIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER);
					if (subcid > 0) {
						openContainersList.emplace_back(std::make_pair(subcid, subContainer));
					}
				}
			}
		}
	}

	std::sort(openContainersList.begin(), openContainersList.end(), [](const std::pair<uint8_t, Container*>& left, const std::pair<uint8_t, Container*>& right) {
		return left.first < right.first;
	});

	for (auto& it : openContainersList) {
		addContainer(it.first - 1, it.second);
		onSendContainer(it.second);
	}
}

Thank you, tested with X-log out and crash, worked well, i'll update the pull request

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

0.0% Coverage
0.0% Duplication