feat: break src/CMakeLists into smaller chunks #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrossi
force-pushed
the
lucas/break-cmake-down-into-modules
branch
from
61d1242 to
d75d40d
Compare
lgrossi
force-pushed
the
lucas/break-cmake-down-into-modules
branch
24 times, most recently
from
0cf9e31 to
74a63dd
Compare
lgrossi
force-pushed
the
lucas/break-cmake-down-into-modules
branch
from
e72ecd5 to
2bf8d03
Compare
|
Kudos, SonarCloud Quality Gate passed! |
luan
approved these changes
Aug 20, 2023
This was referenced Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our currenct CMakeList file is pretty big and hard to understand/edit. This makes it quite rigid to adapt and to break down, specially aiming to have more modular dependencies.
In this PR we are breaking down the CMakeList file into smaller chunks, with specific goals.
We are also breaking down our targets, instead of a standalone executable, we build a library first, to which our executable links. That moves most of our setup to the lib, making the executable definition quite straightforward. This also give us a flexibility of reusing this library, e.g. for tests.
In this MR we also add a small PoC adding tests to our CMake flow, using the new library in the tests context.