improve: change "RaidEvent*" pointer to use std::shared_ptr #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luan
approved these changes
Aug 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a significant refactoring of the code, replacing the use of 'RaidEvent*' raw pointers with std::shared_ptr. This modernization enhances memory management, making the code more robust and safe. By utilizing smart pointers, we ensure better control over the memory lifecycle and reduce the risk of memory leaks and undefined behaviour. This change aligns with modern C++ best practices and contributes to the overall quality and maintainability of the codebase.