-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: organize main and loaders #1392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Aug 13, 2023
004bd87
to
6ab0969
Compare
7d12501
to
5d72a57
Compare
6ab0969
to
e3d7f4e
Compare
4dbd9ec
to
c2c931b
Compare
dudantas
reviewed
Aug 14, 2023
e3d7f4e
to
1f1d2c2
Compare
d5084b2
to
6f44ec5
Compare
565560d
to
9b5b90e
Compare
dudantas
approved these changes
Aug 15, 2023
18e2f3d
to
9b5b90e
Compare
1f1d2c2
to
bea4f1c
Compare
9b5b90e
to
cb4543d
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Leveraging the DI and aiming to have a more decoupled structure in the future, this PR aims to reorganize the initialization flow, giving it a dedicated server class and breaking it down in smaller functions.