feat: move all globals behind di #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
from
cfd2077 to
c6c97f5
Compare
lgrossi
force-pushed
the
lucas/add-fundamental-concepts-for-future-improvements
branch
from
ba4f2ea to
67ca360
Compare
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
from
c6c97f5 to
34afb41
Compare
lgrossi
force-pushed
the
lucas/add-fundamental-concepts-for-future-improvements
branch
from
67ca360 to
807b906
Compare
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
2 times, most recently
from
4bab96f to
2caab6a
Compare
lgrossi
force-pushed
the
lucas/add-fundamental-concepts-for-future-improvements
branch
2 times, most recently
from
750b319 to
0b67e41
Compare
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
from
2caab6a to
66c3ce7
Compare
lgrossi
force-pushed
the
lucas/add-fundamental-concepts-for-future-improvements
branch
from
0b67e41 to
e8e24e6
Compare
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
2 times, most recently
from
8bb385e to
c43e465
Compare
lgrossi
force-pushed
the
lucas/add-fundamental-concepts-for-future-improvements
branch
from
e8e24e6 to
60f525e
Compare
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
from
c43e465 to
a9fb3ac
Compare
lgrossi
force-pushed
the
lucas/add-fundamental-concepts-for-future-improvements
branch
5 times, most recently
from
0c63d7a to
7933279
Compare
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
from
a9fb3ac to
e163744
Compare
lgrossi
force-pushed
the
lucas/add-fundamental-concepts-for-future-improvements
branch
2 times, most recently
from
1677d22 to
7648476
Compare
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
from
e163744 to
e89f1be
Compare
lgrossi
changed the base branch from
lucas/add-fundamental-concepts-for-future-improvements
to
main
lgrossi
force-pushed
the
lucas/move-all-globals-behind-di
branch
from
e89f1be to
7739e15
Compare
luan
approved these changes
Aug 13, 2023
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we've introduced a DI container using BoostDI.
This PR now aims to move all the singletons and shared global instances behind the DI container, making sure that everyone uses a single source of truth for instanciation of shared dependencies (the container).
This is done using the inject<>() function, to reduce the effort needed. However, the desired approach is to have injection in the constructor level, to reduce the risks of mutability and inconsistencies. For now, using inject<>() is a nice step in between.
Type of change
Please delete options that are not relevant.
New feature (non-breaking change which adds functionality)
Checklist