fix: magic effects on old protocol #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
delphinusryetropical
approved these changes
Jul 22, 2023
majestyotbr
approved these changes
Jul 25, 2023
QuebradaZN
approved these changes
Jul 25, 2023
|
Muito bom, testado e aprovado! |
luanluciano93
approved these changes
Jul 25, 2023
dudantas
approved these changes
Jul 26, 2023
luan
added a commit
that referenced
this pull request
Jul 27, 2023
…system * upstream/main: (73 commits) feat: introduce db transaction guard for muto-managed transactions (#738) fix: urmahlullu concurrency (#1302) feat: register sanguine items (#1298) fix: default parameter for challenge creature's lua function (#1296) feat: add elemental concoctions (#1304) fix: magic effects on old protocol (#1294) fix: force clean map when loading custom overlay (#1299) improve: a few content fixes (#1301) fix: prevent special characters in house list (#1306) fix: tick down prem days (#1303) fix: bestiary betterment counting cumulatively (#1307) improve: rework in solution build (#1292) fix: check for player before using variable (#1297) fix: error in spell of arachnophobica and add neutral damage enum (#1282) fix: cyclopedia debug related to client 13.20 (#1289) fix: loop related to creature destination inside a teleport items (#1288) improve: refactor waiting list logic and fix windows shutdown (#1280) feat: protocol update for 13.20 (#1269) build: fix docker build, change to ubuntu 23.04 (#1281) build: fix gha/workflows (#1277) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The magic effects were not working for the old protocols as it std::max was being used, making all effects of type 0xFF (255), even so, the approach isn't good, in my opinion the best approach is instead of using std::min just don't send effects of type 256+, because using std::min would just change all the effects after 255 to 255 instead.
Behaviour
Actual
Old clients don't receive magic effects
Expected
Old clients should receive magic effects up to type 255
Fixes #1284
Type of change
How Has This Been Tested
Test Configuration:
Checklist