fix: remove old lootcontainer flag #1253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this:
QUICKLOOTCONTAINER
wasn't being removed from previous container, so when we saved it iniologindata.cpp
both the new container and the old were getting the attribute. This caused an inconsistent behavior where the item that ended up first in the table would win, if that item was the old one, the change in loot containers was then reverted.This change always removed the attribute from the current container for the category before adding it to the new one, this makes it deterministically set the correct attribute.
Type of change
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration