Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove old lootcontainer flag #1253

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix: remove old lootcontainer flag #1253

merged 2 commits into from
Jul 17, 2023

Conversation

luan
Copy link
Contributor

@luan luan commented Jul 14, 2023

Before this: QUICKLOOTCONTAINER wasn't being removed from previous container, so when we saved it in iologindata.cpp both the new container and the old were getting the attribute. This caused an inconsistent behavior where the item that ended up first in the table would win, if that item was the old one, the change in loot containers was then reverted.

This change always removed the attribute from the current container for the category before adding it to the new one, this makes it deterministically set the correct attribute.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tried before and after

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@luan luan merged commit 209511c into main Jul 17, 2023
@beats-dh beats-dh deleted the luan/fix-quickloot-save branch July 17, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants