fix: use/move/trade/add/remove item from house logic

[dudantas]

Description

The guest player (aleta sio) will no longer be able to:
• Using an item inside the house
• Trade an item inside the house
• Give "use with" item inside house
• Move item inside house
And no other type of interaction with the item (except the "look")

It is also no longer allowed to throw items in the house, unless you are a subowner (aleta som).

Behaviour

Actual

Guest can execute actions.

Expected

Guest cannot more execute actions.

Type of change

• Bug fix (non-breaking change which fixes an issue)

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
21.6% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[luan]

The config ONLY_INVITED_CAN_MOVE_HOUSE_ITEMS makes one think that guests would be able to move stuff. Invited -> Guest. I think the functionality implemented here would be good around something like ONLY_SUBOWNER_CAN_MOVE_HOUSE_ITEMS -- I thought the idea with ONLY_INVITED_CAN_MOVE_HOUSE_ITEMS is to prevent invites with * from moving items. But maybe I misunderstood how it was supposed to work

[dudantas]

The config ONLY_INVITED_CAN_MOVE_HOUSE_ITEMS makes one think that guests would be able to move stuff. Invited -> Guest. I think the functionality implemented here would be good around something like ONLY_SUBOWNER_CAN_MOVE_HOUSE_ITEMS -- I thought the idea with ONLY_INVITED_CAN_MOVE_HOUSE_ITEMS is to prevent invites with * from moving items. But maybe I misunderstood how it was supposed to work

Actually I just implemented the logic that is already used elsewhere. But, it is already used that way, I just followed what was already done.

But I don't know if there's a need to create a new tag, I think the two can be used for the same thing without any problem, it doesn't seem to me that the name "invited" necessarily means who was invited (from the list aleta sio/aleta som) but yes who has access to house. As soon as the if handles both cases, both the invited and the guest. If necessary, we can add a new tag, but I don't particularly see the need, it will be just another tag without much use.