feat: ingol + iksupan monsters #1224

luan · 2023-07-09T04:57:55Z

Description

Adds regular creatures, their spawns, and the very basics to get to and from Iksupan. Ingol is missing an NPC to get to / from it still, one can add a way to get there with a teleport. All quest doors on the island can be oepn with the storage Storage.Quest.U13_10.CradleOfMonsters.Access.LowerIngol with the exception of the task-specific doors.

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested fighting the creatures and compared with youtube vids/wiki data
Tested the maps themselves (and uploaded the on discord after review)

Test Configuration:

Server Version: main + this PR
Client: 13.16
Operating System: Ubuntu 22.04

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I checked the PR checks reports
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works

luan · 2023-07-09T19:33:01Z

@thunerm can you stop commenting on every PR that uses dangling commas saying it's a typo? That's not a typo it's a style choice. It doesn't break anything and it makes it much easier to edit later

majestyotbr · 2023-07-09T19:45:20Z

Updated global map with iksupan and ingol is available.
Release: https://github.com/opentibiabr/canary/releases/download/v1.5.0/otservbr.otbm
Gitbook: https://docs.opentibiabr.com/projects/canary#updated-otservbr-global-map
Thanks @luan for your contribution.

lgrossi · 2023-07-09T21:59:08Z

@thunerm você pode parar de comentar em cada PR que usa vírgulas dizendo que é um erro de digitação? Isso não é um erro de digitação, é uma escolha de estilo. Não quebra nada e facilita muito a edição posterior

olha, ele pode acusar nulo na distro quando mata o monstro.

It has nothing to do with the commas, lua has a flexible style where you can put or not the comma in the last element of the array. While some lanagues enforce it (like golang), most enforce not having it (like cpp and java) and some allows both (lua, php, javascript). As far as I'm concerned, this is not a big deal and we don't have a clear code style agreement about that.

If you ask me, having them makes editing easier by the simple fact that you can change the array order without needing to add/remove commas. But that's nothing more than a preference, there is no null pointer or bug related to this.

Seems that chatgpt 4 thinks the same: