Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rings attributes #1175

Merged
merged 2 commits into from
Jun 12, 2023
Merged

fix: rings attributes #1175

merged 2 commits into from
Jun 12, 2023

Conversation

Valleze
Copy link
Contributor

@Valleze Valleze commented Jun 11, 2023

Description

  • Fixado nome do item com id: 39182 em unscripted_equipments.lua. De charged alicorn ring para alicorn ring.
  • Adicionado defesa elemental holy 4% e death 4% no item Charged Alicorn Ring id: 39181.
  • Fixado nome do item de id: 39184 em items.xml e em unscripted_equipments.lua. De charged arcanomancer ring para charged arcanomancer sigil.
  • Fixado nome do item de id: 31557 e 31616 em items.xml e em unscripted_equipments.lua. De blister ring para enchanted blister ring.
  • Fixado nome do item de id: 32621 e 32635 em items.xml e em unscripted_equipments.lua. De ring of souls para enchanted ring of souls. Removido o texto de descrição do item id: 32635.
  • Removidas as restriçõoes de level e vocação do item Lion Ring id: 34080.
  • Fixado o peso do item Ring of Wishes id: 3245. De 90 para 50.
  • Fixado bônus de protção física do item Spiritthorn Ring, id: 39179. De 8% para 2%.
  • Fixados os IDs dos itens Suspicious Signet Ring e Family Signet Ring em unscripted_equipments.lua. Estavam trocados.
  • Fixado o peso do item Unstable Ring of Ending id: 20209. De 0 para 60.

Behaviour

Actual

Alguns atributos e nomes de alguns rings errados.

Type of change

Alterações feitas para que os itens afetados fiquem mais fieis ao global.

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

Após as alterações, nenhum erro/bug ocorreu na distro.

Test Configuration:

  • Server Version:
  • Client:
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@murilo09 murilo09 changed the title Fix: rings attributes fix: rings attributes Jun 12, 2023
@dudantas dudantas merged commit 3aaa4b4 into opentibiabr:main Jun 12, 2023
@Valleze Valleze deleted the Fix-rings branch June 12, 2023 14:09
libergod referenced this pull request in libergod/canary_baiak Jul 6, 2023
luan pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants