Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: distance weapons attributes #1167

Merged
merged 1 commit into from
Jun 10, 2023
Merged

fix: distance weapons attributes #1167

merged 1 commit into from
Jun 10, 2023

Conversation

Valleze
Copy link
Contributor

@Valleze Valleze commented Jun 9, 2023

Description

  • Adicionado o atributo perfectshootdamage 20 e perfectshotrange 4 no item Eldritch Quiver. Atributos adicionados em forma de comentário em items.xml.
  • Adicionado restrição de level 80 no item Assassin Star.
  • Adicionado atributo defense 1 no item Broken iks Spear.
  • Adicionado restrição de level 42 no item Enchanted Spear.
  • Adicionado restrição de level 60 no item Glooth Spear.
  • Adicionado restrição de level 20 no item Hunting Spear.
  • Adicionado restrição de level 60 no item Leaf Star. E fixado sua range de 4 para 5.
  • Adicionado restrição de vocação None no item Mean Paladin Spear. Apenas player sem vocação pode usar.
  • Adicionado restrição de level 25 no item Royal Spear.
  • Adicionado restrição de level 120 para usar Royal Star.
  • Fixado ID do item Shapeshifter Ring na função deequip do ID 907.
  • Adicionado o item Throwing Cake em unscripted_equipments.lua.
  • Adicionado o item Viper Star em unscripted_equipments.lua.
  • Fixado o atributo hitchance do item Crossbow of Destruction id: 27456. De 6 pra 5.
  • Fixado o atributo hitchance do item Naga Crossbow id: 39159. De 7 para 6.
  • Fixado level mínimo para usar o item The Devileye. De 120 para 100.
  • Fixado bônus de skill distance do item Bow of Cataclysm id: 31581. De 4 para 2.
  • Fixados os atributos hitchance e attack do item Bow of Destruction id: 27455. Ambos de 6 para 5.
  • Fixado o atributo hitchance do item Lion Longbow id: 34150. De 4 para 6.
  • Fixado level mínimo para usar o item Living Vine Bow id: 29147. De 250 para 220. Fixados os atributos hitchance e attack do mesmo de 6 para 5.
  • Fixado o peso o item Silkweaver Bow id: 8029. De 2200 para 2500.

Behaviour

Actual

Informações e/ou requisitos dos itens em questão, errados / faltando.

Expected

Fixados informações e requisitos.

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

Após a mudança, não ocorreu nenhum erro ou bug na distro.

Test Configuration:

  • Server Version:
  • Client:
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@majestyotbr majestyotbr changed the title fix: distance weapons attributes and add eldritch quiver perfectShoot… fix: distance weapons attributes Jun 10, 2023
@dudantas dudantas merged commit 0bf40d1 into opentibiabr:main Jun 10, 2023
libergod referenced this pull request in libergod/canary_baiak Jun 16, 2023
@libergod
fix: distance weapons attributes #1167
e8e6b21
@Valleze Valleze deleted the Fix-distance-weapons-and-add-eldritch-quiver-perfectShoot-attribute branch June 28, 2023 14:30
luan pushed a commit that referenced this pull request Jul 11, 2023
@Valleze
fix: distance weapons attributes (#1167)
f590fd4 
• Added the attributes perfectshootdamage 20 and perfectshotrange 4 to the item Eldritch Quiver. Attributes added as comments in items.xml.
• Added level restriction 80 to the item Assassin Star.
• Added attribute defense 1 to the item Broken iks Spear.
• Added level restriction 42 to the item Enchanted Spear.
• Added level restriction 60 to the item Glooth Spear.
• Added level restriction 20 to the item Hunting Spear.
• Added level restriction 60 to the item Leaf Star. Also fixed its range from 4 to 5.
• Added vocation restriction None to the item Mean Paladin Spear. Only non-vocational players can use it.
• Added level restriction 25 to the item Royal Spear.
• Added level restriction 120 to use the item Royal Star.
• Fixed ID of the item Shapeshifter Ring in the deequip function to ID 907.
• Added the item Throwing Cake to unscripted_equipments.lua.
• Added the item Viper Star to unscripted_equipments.lua.
• Fixed the hitchance attribute of item Crossbow of Destruction id: 27456. Changed from 6 to 5.
• Fixed the hitchance attribute of item Naga Crossbow id: 39159. Changed from 7 to 6.
• Fixed minimum level to use the item The Devileye. Changed from 120 to 100.
• Fixed skill distance bonus of item Bow of Cataclysm id: 31581. Changed from 4 to 2.
• Fixed the hitchance and attack attributes of item Bow of Destruction id: 27455. Both changed from 6 to 5.
• Fixed the hitchance attribute of item Lion Longbow id: 34150. Changed from 4 to 6.
• Fixed minimum level to use the item Living Vine Bow id: 29147. Changed from 250 to 220. Also fixed the hitchance and attack attributes from 6 to 5.
• Fixed the weight of item Silkweaver Bow id: 8029. Changed from 2200 to 2500.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majestyotbr majestyotbr majestyotbr approved these changes

@Glatharth Glatharth Glatharth approved these changes

Assignees
No one assigned
Labels
Area: Datapack Core Area: Datapack Global
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Valleze @majestyotbr @Glatharth @dudantas