Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shadow nexus inquisition item decay #1150

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Conversation

andrelcb
Copy link
Contributor

@andrelcb andrelcb commented Jun 2, 2023

Ajustando shadow nexus da inquisiton que nao transformava no item de decay.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Ajustando shadow nexus da inquisiton que nao transformava no item de decay.
@hriqueXimenes
Copy link

Tenta seguir o nome das PR’s que ja estao abertas. Feat. Fix. Etc

@majestyotbr majestyotbr changed the title AJUSTE SHADOW NEXUS INQUISITION fix: shadow nexus inquisition item decay Jun 3, 2023
Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use ";" after the end of the lines, it's a c++ syntax, lua doesn't need it. Also, using the item after it has been deleted is not good, it is better to increment and then remove it. You should also check the output of "Game.createItem" and be careful with the indentation.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dudantas dudantas merged commit bac9e7d into opentibiabr:main Jun 12, 2023
luan pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants