-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shadow nexus inquisition item decay #1150
Conversation
Ajustando shadow nexus da inquisiton que nao transformava no item de decay.
data-otservbr-global/scripts/actions/quests/others/holy_water.lua
Outdated
Show resolved
Hide resolved
Tenta seguir o nome das PR’s que ja estao abertas. Feat. Fix. Etc |
Co-authored-by: thunerm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to use ";" after the end of the lines, it's a c++ syntax, lua doesn't need it. Also, using the item after it has been deleted is not good, it is better to increment and then remove it. You should also check the output of "Game.createItem" and be careful with the indentation.
data-otservbr-global/scripts/actions/quests/others/holy_water.lua
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Ajustando shadow nexus da inquisiton que nao transformava no item de decay.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Behaviour
Actual
Do this and that doesn't happens
Expected
Do this and that happens
Fixes #issuenumber
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist