Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add player skill wrong displaying to client #1066

Merged
merged 1 commit into from
May 8, 2023

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented May 6, 2023

Description

Skill goes up but does not update on the client.
Revert wrong change from 46d1080 (#516)

Behaviour

Actual

Skill do not update in the client.

Expected

Skill up normal in the client.
image
image

Fixes #1042

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@travisani travisani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine

@dudantas dudantas merged commit fc7697a into main May 8, 2023
@dudantas dudantas deleted the wrong-display-player-skill branch May 8, 2023 11:56
libergod referenced this pull request in libergod/canary_baiak May 31, 2023
luan pushed a commit that referenced this pull request Jul 11, 2023
Skill goes up but does not update on the client.
Revert wrong change from 187bb9f (#516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual bug on client 13. Attempt to upgrade skills!
6 participants