fix: suppress get byte log

opentibiabr · Dec 21, 2024 · 34d26fc · 34d26fc
1 parent 34b6fa8
commit 34d26fc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/server/network/message/networkmessage.cpp b/src/server/network/message/networkmessage.cpp
@@ -45,10 +45,12 @@ int32_t NetworkMessage::decodeHeader() {
 }
 
 // Simply read functions for incoming message
-uint8_t NetworkMessage::getByte(const std::source_location &location /*= std::source_location::current()*/) {
+uint8_t NetworkMessage::getByte(bool suppresLog /*= false*/, const std::source_location &location /*= std::source_location::current()*/) {
 	// Check if there is at least 1 byte to read
 	if (!canRead(1)) {
-		g_logger().error("[{}] Not enough data to read a byte. Current position: {}, Length: {}. Called line {}:{} in {}", __FUNCTION__, info.position, info.length, location.line(), location.column(), location.function_name());
+		if (!suppresLog) {
+			g_logger().error("[{}] Not enough data to read a byte. Current position: {}, Length: {}. Called line {}:{} in {}", __FUNCTION__, info.position, info.length, location.line(), location.column(), location.function_name());
+		}
 		return {};
 	}
 
@@ -113,7 +115,7 @@ Position NetworkMessage::getPosition() {
 	Position pos;
 	pos.x = get<uint16_t>();
 	pos.y = get<uint16_t>();
-	pos.z = getByte();
+	pos.z = getByte(true);
 	return pos;
 }
 

diff --git a/src/server/network/message/networkmessage.hpp b/src/server/network/message/networkmessage.hpp
@@ -34,7 +34,7 @@ class NetworkMessage {
 	}
 
 	// simply read functions for incoming message
-	uint8_t getByte(const std::source_location &location = std::source_location::current());
+	uint8_t getByte(bool suppresLog = false, const std::source_location &location = std::source_location::current());
 
 	uint8_t getPreviousByte();
 

diff --git a/src/server/network/protocol/protocolgame.cpp b/src/server/network/protocol/protocolgame.cpp
@@ -2176,7 +2176,7 @@ void ProtocolGame::parseTaskHuntingAction(NetworkMessage &msg) {
 
 	uint8_t slot = msg.getByte();
 	uint8_t action = msg.getByte();
-	bool upgrade = msg.getByte() != 0;
+	bool upgrade = msg.getByte(true) != 0;
 	auto raceId = msg.get<uint16_t>();
 
 	if (!g_configManager().getBoolean(TASK_HUNTING_ENABLED)) {